fix: Cancel alert is not appearing to all native filters modal fields

[michael-s-molina]

SUMMARY

Monitors changes to all fields of the native filters modal. Previously, the cancel alert was not shown when some fields changed.

@junlincc @jinghua-qa @adam-stasiak

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

screen-recording-2021-07-28-at-112714-am_cHb2HCCC.mp4

screen-recording-2021-07-28-at-112305-am_FpbHduJJ.mp4

TESTING INSTRUCTIONS

• Go to the native filters modal
• Create, edit, delete filters
• Check if the cancel alert is displayed consistently

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[junlincc]

@michael-s-molina do you mind attaching BEFORE and AFTER video/gif? thanks!

[codecov]

Codecov Report

Merging #15925 (6f8dcf2) into master (eb78f43) will decrease coverage by 0.00%.
The diff coverage is 56.00%.

❗ Current head 6f8dcf2 differs from pull request most recent head 897c9bc. Consider uploading reports for the commit 897c9bc to get more accurate results

@@            Coverage Diff             @@
##           master   #15925      +/-   ##
==========================================
- Coverage   76.98%   76.98%   -0.01%     
==========================================
  Files         988      988              
  Lines       52379    52313      -66     
  Branches     6623     6623              
==========================================
- Hits        40326    40273      -53     
+ Misses      11829    11817      -12     
+ Partials      224      223       -1     

Flag	Coverage Δ
javascript	71.53% <56.00%> (-0.04%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...nativeFilters/FiltersConfigModal/Footer/Footer.tsx	100.00% <ø> (+5.26%)	⬆️
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx	73.13% <47.61%> (-1.44%)	⬇️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx	95.40% <100.00%> (+0.10%)	⬆️
superset/charts/post_processing.py	14.63% <0.00%> (-65.37%)	⬇️
superset-frontend/src/views/CRUD/utils.tsx	64.16% <0.00%> (-4.43%)	⬇️
superset/reports/notifications/slack.py	87.50% <0.00%> (-2.67%)	⬇️
...set-frontend/src/views/CRUD/welcome/ChartTable.tsx	72.83% <0.00%> (-1.85%)	⬇️
...perset-frontend/src/views/CRUD/welcome/Welcome.tsx	81.30% <0.00%> (-1.52%)	⬇️
...frontend/src/views/CRUD/welcome/DashboardTable.tsx	64.51% <0.00%> (-1.42%)	⬇️
superset/reports/notifications/base.py	95.65% <0.00%> (-0.19%)	⬇️
... and 20 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eb78f43...897c9bc. Read the comment docs.

[michael-s-molina]

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true

[github-actions]

@michael-s-molina Ephemeral environment spinning up at http://54.188.167.53:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[geido]

Hello @michael-s-molina. Thanks for the fix.

I have noticed that when changing an existing filter and then creating a new one, when saving it says "1 unsaved filter". However, I would expect that to say "2 unsaved filters" as I did changes to two filters that were not saved yet. This is a minor thing though.

scroll.inconsist.mp4

[michael-s-molina]

Hello @michael-s-molina. Thanks for the fix.

I have noticed that when changing an existing filter and then creating a new one, when saving it says "1 unsaved filter". However, I would expect that to say "2 unsaved filters" as I did changes to two filters that were not saved yet. This is a minor thing though.

scroll.inconsist.mp4

@geido I made a change to make the cancel message more generic because tracking exactly which filter changed would require additional logic. Also because the previous strategy of listing the names of the filters that changed is not suitable when the number of changed filters is high.

[michael-s-molina]

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true

[github-actions]

@michael-s-molina Ephemeral environment spinning up at http://34.213.224.190:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[jinghua-qa]

LGTM!

cancel.alert.mov

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.