-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(dashboard): Add required message in the tooltip for the time range filter #15941
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15941 +/- ##
==========================================
- Coverage 76.99% 76.99% -0.01%
==========================================
Files 988 988
Lines 52304 52306 +2
Branches 7124 6621 -503
==========================================
+ Hits 40272 40273 +1
- Misses 11807 11809 +2
+ Partials 225 224 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geido Can you change the color on hover to red? RangeFilterPlugin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@geido Can you change the color on hover to red? RangeFilterPlugin
Hey @michael-s-molina. Now the red border is kept also on hover for consistency. You can check again. Thank you! |
/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true |
@michael-s-molina Ephemeral environment spinning up at http://18.236.92.148:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
…e filter (apache#15941) * Add required msg in tooltip * Fix lint * Keep red border on hover
…e filter (apache#15941) * Add required msg in tooltip * Fix lint * Keep red border on hover
…e filter (apache#15941) * Add required msg in tooltip * Fix lint * Keep red border on hover
…e filter (apache#15941) * Add required msg in tooltip * Fix lint * Keep red border on hover
SUMMARY
This PR adds a "Default value is required" message in the tooltip for a time range filter when a default value is required.
Fixes: #15375
BEFORE
Screen.Recording.2021-06-24.at.2.00.22.PM.mov
AFTER
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION