Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): Add required message in the tooltip for the time range filter #15941

Merged
merged 3 commits into from
Jul 30, 2021
Merged

fix(dashboard): Add required message in the tooltip for the time range filter #15941

merged 3 commits into from
Jul 30, 2021

Conversation

geido
Copy link
Member

@geido geido commented Jul 29, 2021

SUMMARY

This PR adds a "Default value is required" message in the tooltip for a time range filter when a default value is required.

Fixes: #15375

BEFORE

Screen.Recording.2021-06-24.at.2.00.22.PM.mov

AFTER

Screen Shot 2021-07-29 at 11 31 14

TESTING INSTRUCTIONS

  1. Create a time range filter with the 'Required ' option selected
  2. Go to the dashboard and click ' Clear All'
  3. Go with your mouse over the filter and check the message in the tooltip

ADDITIONAL INFORMATION

@geido
Copy link
Member Author

geido commented Jul 29, 2021

@apache apache deleted a comment from github-actions bot Jul 29, 2021
@apache apache deleted a comment from github-actions bot Jul 29, 2021
@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #15941 (2e0f9b8) into master (ac9c137) will decrease coverage by 0.00%.
The diff coverage is 80.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15941      +/-   ##
==========================================
- Coverage   76.99%   76.99%   -0.01%     
==========================================
  Files         988      988              
  Lines       52304    52306       +2     
  Branches     7124     6621     -503     
==========================================
+ Hits        40272    40273       +1     
- Misses      11807    11809       +2     
+ Partials      225      224       -1     
Flag Coverage Δ
javascript 71.55% <80.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/filters/components/Time/TimeFilterPlugin.tsx 86.66% <ø> (ø)
...nts/controls/DateFilterControl/DateFilterLabel.tsx 66.66% <80.00%> (-0.27%) ⬇️
superset-frontend/src/views/CRUD/hooks.ts 47.80% <0.00%> (ø)
...end/src/SqlLab/components/RunQueryActionButton.tsx 65.11% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac9c137...2e0f9b8. Read the comment docs.

@geido geido closed this Jul 29, 2021
@geido geido reopened this Jul 29, 2021
Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geido Can you change the color on hover to red? RangeFilterPlugin

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@geido Can you change the color on hover to red? RangeFilterPlugin

@geido
Copy link
Member Author

geido commented Jul 29, 2021

@geido Can you change the color on hover to red? RangeFilterPlugin

Hey @michael-s-molina. Now the red border is kept also on hover for consistency. You can check again. Thank you!

@michael-s-molina
Copy link
Member

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true

@github-actions
Copy link
Contributor

@michael-s-molina Ephemeral environment spinning up at http://18.236.92.148:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@geido geido merged commit c2e4290 into apache:master Jul 30, 2021
@geido geido moved this from In Review to Done in Community Usability Bash! 🐛🐞🕷 Jul 30, 2021
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
…e filter (apache#15941)

* Add required msg in tooltip

* Fix lint

* Keep red border on hover
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
…e filter (apache#15941)

* Add required msg in tooltip

* Fix lint

* Keep red border on hover
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
…e filter (apache#15941)

* Add required msg in tooltip

* Fix lint

* Keep red border on hover
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
…e filter (apache#15941)

* Add required msg in tooltip

* Fix lint

* Keep red border on hover
@mistercrunch mistercrunch added the 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels label Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.3.0
Projects
No open projects
3 participants