chore(explore): Create new entrypoints for Echarts Timeseries #15942

kgabryje · 2021-07-29T10:46:26Z

SUMMARY

This PR adds the new charts/entry points implemented in apache-superset/superset-ui#1249. For more details, see description.
apache-superset/superset-ui#1249 must be merged before this PR! After that, the superset-ui versions need to be bumped

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

See apache-superset/superset-ui#1249

TESTING INSTRUCTIONS

Create Echarts Area Chart. Verify that you can change series type to Line, Smooth Line, Step Start/Middle/End.
Create Line, Smooth Line, Bar, Scatter, Step Start/Middle/End Timeseries chart. Verify that you CANNOT change the series type or select "area".
Create Timeseries Chart. Verify that all series types and "area" checkbox are available

ADDITIONAL INFORMATION

Has associated issue:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

@junlincc @villebro

superset-frontend/src/visualizations/presets/MainPreset.js

codecov · 2021-07-29T11:12:20Z

Codecov Report

Merging #15942 (598f0ce) into master (1917464) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #15942   +/-   ##
=======================================
  Coverage   76.80%   76.80%           
=======================================
  Files         995      995           
  Lines       52866    52866           
  Branches     6713     6713           
=======================================
  Hits        40605    40605           
  Misses      12035    12035           
  Partials      226      226

Flag	Coverage Δ
javascript	`71.29% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...ponents/controls/VizTypeControl/VizTypeGallery.tsx	`94.83% <ø> (ø)`
...-frontend/src/visualizations/presets/MainPreset.js	`0.00% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1917464...598f0ce. Read the comment docs.

villebro · 2021-08-04T16:37:48Z

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true

github-actions · 2021-08-04T16:39:48Z

@villebro Ephemeral environment spinning up at http://34.214.9.184:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

geido

LGTM!

villebro

Tested to the best of my ability, and all looks solid

github-actions · 2021-08-04T18:04:40Z

Ephemeral environment shutdown and build artifacts deleted.

villebro · 2021-08-04T18:23:53Z

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true

github-actions · 2021-08-04T18:25:12Z

@villebro Container image not yet published for this PR. Please try again when build is complete.

github-actions · 2021-08-04T18:25:12Z

@villebro Ephemeral environment creation failed. Please check the Actions logs for details.

villebro · 2021-08-04T20:01:09Z

/testenv up FEATURE_DASHBOARD_NATIVE_FILTERS=true FEATURE_DASHBOARD_CROSS_FILTERS=true

github-actions · 2021-08-04T20:03:03Z

@villebro Ephemeral environment spinning up at http://52.33.88.219:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

suddjian

Tested, LGTM

github-actions · 2021-08-05T05:28:36Z

Ephemeral environment shutdown and build artifacts deleted.

rosemarie-chiu · 2021-08-05T06:51:22Z

🏷 2021.31

…#15942) * feat(explore): Create new entrypoints for Echarts Timeseries * Change order of some charts * bump superset-ui * also bump echarts package * fix UT Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> (cherry picked from commit a59d458)

* feat(explore): Create new entrypoints for Echarts Timeseries * Change order of some charts * bump superset-ui * also bump echarts package * fix UT Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> (cherry picked from commit a59d458)

…#15942) * feat(explore): Create new entrypoints for Echarts Timeseries * Change order of some charts * bump superset-ui * also bump echarts package * fix UT Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>

…#15942) * feat(explore): Create new entrypoints for Echarts Timeseries * Change order of some charts * bump superset-ui * also bump echarts package * fix UT Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> (cherry picked from commit a59d458)

…#15942) * feat(explore): Create new entrypoints for Echarts Timeseries * Change order of some charts * bump superset-ui * also bump echarts package * fix UT Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com>

…#15942) * feat(explore): Create new entrypoints for Echarts Timeseries * Change order of some charts * bump superset-ui * also bump echarts package * fix UT Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> (cherry picked from commit a59d458)

…#15942) * feat(explore): Create new entrypoints for Echarts Timeseries * Change order of some charts * bump superset-ui * also bump echarts package * fix UT Co-authored-by: Ville Brofeldt <ville.v.brofeldt@gmail.com> (cherry picked from commit bf0cd49)

kgabryje requested review from zhaoyongjie and villebro July 29, 2021 10:46

pull-request-size bot added the size/M label Jul 29, 2021

villebro reviewed Jul 29, 2021

View reviewed changes

superset-frontend/src/visualizations/presets/MainPreset.js Outdated Show resolved Hide resolved

junlincc added this to considering in cherry board Aug 3, 2021

junlincc added the rush! Requires immediate attention label Aug 3, 2021

feat(explore): Create new entrypoints for Echarts Timeseries

64e4600

pull-request-size bot added size/S and removed size/M labels Aug 4, 2021

Change order of some charts

255fefd

kgabryje force-pushed the feat/timeseries-entrypoints branch from b2db549 to 255fefd Compare August 4, 2021 14:47

pull-request-size bot added size/M and removed size/S labels Aug 4, 2021

villebro added 3 commits August 4, 2021 19:09

Merge branch 'master' into feat/timeseries-entrypoints

aed66ab

bump superset-ui

be2a780

also bump echarts package

8fefba2

fix UT

598f0ce

geido approved these changes Aug 4, 2021

View reviewed changes

villebro approved these changes Aug 4, 2021

View reviewed changes

kgabryje closed this Aug 4, 2021

kgabryje reopened this Aug 4, 2021

kgabryje changed the title ~~feat(explore): Create new entrypoints for Echarts Timeseries~~ chore(explore): Create new entrypoints for Echarts Timeseries Aug 4, 2021

geido mentioned this pull request Aug 4, 2021

fix(Explore): Show the tooltip only when label does not fit the container in METRICS/FILTERS/GROUP BY/SORT BY of the DATA panel #16060

Merged

8 tasks

suddjian approved these changes Aug 4, 2021

View reviewed changes

kgabryje merged commit a59d458 into apache:master Aug 5, 2021

superset-github-bot bot added the preset:2021.31 label Aug 5, 2021

villebro added the v1.3 label Aug 9, 2021

mistercrunch added 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore(explore): Create new entrypoints for Echarts Timeseries #15942

chore(explore): Create new entrypoints for Echarts Timeseries #15942

kgabryje commented Jul 29, 2021

codecov bot commented Jul 29, 2021 •

edited

Loading

villebro commented Aug 4, 2021

github-actions bot commented Aug 4, 2021

geido left a comment

villebro left a comment

github-actions bot commented Aug 4, 2021

villebro commented Aug 4, 2021

github-actions bot commented Aug 4, 2021

github-actions bot commented Aug 4, 2021

villebro commented Aug 4, 2021

github-actions bot commented Aug 4, 2021

suddjian left a comment

github-actions bot commented Aug 5, 2021

rosemarie-chiu commented Aug 5, 2021

chore(explore): Create new entrypoints for Echarts Timeseries #15942

chore(explore): Create new entrypoints for Echarts Timeseries #15942

Conversation

kgabryje commented Jul 29, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

codecov bot commented Jul 29, 2021 • edited Loading

Codecov Report

villebro commented Aug 4, 2021

github-actions bot commented Aug 4, 2021

geido left a comment

Choose a reason for hiding this comment

villebro left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 4, 2021

villebro commented Aug 4, 2021

github-actions bot commented Aug 4, 2021

github-actions bot commented Aug 4, 2021

villebro commented Aug 4, 2021

github-actions bot commented Aug 4, 2021

suddjian left a comment

Choose a reason for hiding this comment

github-actions bot commented Aug 5, 2021

rosemarie-chiu commented Aug 5, 2021

codecov bot commented Jul 29, 2021 •

edited

Loading