fix: Fix long dashboards screenshot emails #15954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #15954 +/- ##
==========================================
+ Coverage 76.99% 77.13% +0.13%
==========================================
Files 988 996 +8
Lines 52371 55481 +3110
Branches 6621 7308 +687
==========================================
+ Hits 40324 42793 +2469
- Misses 11824 12454 +630
- Partials 223 234 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
hughhhh
force-pushed
the
hugh/fix-report-header
branch
from
166f4fe
to
779d63c
Compare
…/fix-report-header
hughhhh
force-pushed
the
hugh/fix-report-header
branch
from
779d63c
to
b52b033
Compare
betodealmeida
approved these changes
Jul 29, 2021
superset/utils/webdriver.py
Outdated
Comment on lines
47
to
49
| HIDE_NAV = (1,) | ||
| HIDE_NAV_AND_TITLE = (2,) | ||
| REPORT = (3,) |
There was a problem hiding this comment.
Suggested change
| HIDE_NAV = (1,) | |
| HIDE_NAV_AND_TITLE = (2,) | |
| REPORT = (3,) | |
| HIDE_NAV = 1 | |
| HIDE_NAV_AND_TITLE = 2 | |
| REPORT = 3 |
Otherwise the type is not int, but Tuple[int].
| @@ -182,8 +182,9 @@ const DashboardBuilder: FC<DashboardBuilderProps> = () => { | |||
| ? dashboardLayout[rootChildId] | |||
| : undefined; | |||
| const isStandalone = getUrlParam(URL_PARAMS.standalone); | |||
There was a problem hiding this comment.
This was a bit confusing, the name isStandalone suggests that this is a boolean. We should rename this to standaloneMode or something more clear.
superset/utils/webdriver.py
Outdated
| @@ -97,6 +104,7 @@ def get_screenshot( | |||
| self, url: str, element_name: str, user: "User", | |||
| ) -> Optional[bytes]: | |||
|
|
|||
| url = f"{url}?standalone={DashboardStandaloneMode.REPORT}" | |||
There was a problem hiding this comment.
This will break if we change the URL in utils/screenshots.py to include other parameters, it would be safer to parse the URL and append the new parameter programmatically instead of doing string manipulation.
An easy way to do that is using the requests library:
Suggested change
| url = f"{url}?standalone={DashboardStandaloneMode.REPORT}" | |
| from requests.models import PreparedRequest | |
| params = {"standalone": DashboardStandaloneMode.REPORT.value} | |
| req = PreparedRequest() | |
| req.prepare_url(url, params) | |
| url = req.url |
Or we can use urllib.parse, but it's more code: https://stackoverflow.com/a/25580545/807118
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* create serialize json function * create new setting for reports * cleanup * address comments * up the attributes
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* create serialize json function * create new setting for reports * cleanup * address comments * up the attributes
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* create serialize json function * create new setting for reports * cleanup * address comments * up the attributes
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* create serialize json function * create new setting for reports * cleanup * address comments * up the attributes
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Before long reports would have header showing in the middle of the picture. Now i've added a specific
standalonesetting for reports, which will hide the report dashboard and tabs onCapture.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION