New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change dropdown icons from horizontal to vertical #15958
Conversation
Codecov Report
@@ Coverage Diff @@
## master #15958 +/- ##
==========================================
- Coverage 76.99% 76.97% -0.02%
==========================================
Files 988 988
Lines 52371 52391 +20
Branches 6621 6627 +6
==========================================
+ Hits 40324 40330 +6
- Misses 11824 11837 +13
- Partials 223 224 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
@pkdotson I think we should use an icon with less space between the dots to make it shorter. Like the one on Google Drive: |
+1, the spacing of the icon doesn't look right. do we have the icon @michael-s-molina suggested handy somewhere? Reasons for change - menu that opens vertically should be represented by a vertical "three dots" icon versus using a horizontal icon to indicate opening a horizontal menu |
/testenv up |
@rusackas Ephemeral environment spinning up at http://34.219.63.63:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for the cleanup!
Ephemeral environment shutdown and build artifacts deleted. |
* change icons * add size * fix storybook * fix favstar, add new icons, and others * fix lint
* change icons * add size * fix storybook * fix favstar, add new icons, and others * fix lint
* change icons * add size * fix storybook * fix favstar, add new icons, and others * fix lint
* change icons * add size * fix storybook * fix favstar, add new icons, and others * fix lint
SUMMARY
This pr changes the dropdown icons from horizontal to vertical for homepage cards, and datasource editor dropdown.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-07-30.at.1.25.53.PM.mov
TESTING INSTRUCTIONS
Go to homepage and listviews, and explore to checkout new icon
ADDITIONAL INFORMATION