Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change dropdown icons from horizontal to vertical #15958

Merged
merged 6 commits into from Jul 30, 2021

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Jul 29, 2021

SUMMARY

This pr changes the dropdown icons from horizontal to vertical for homepage cards, and datasource editor dropdown.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-07-30.at.1.25.53.PM.mov

TESTING INSTRUCTIONS

Go to homepage and listviews, and explore to checkout new icon

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 29, 2021

Codecov Report

Merging #15958 (016014f) into master (3b9b2c9) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15958      +/-   ##
==========================================
- Coverage   76.99%   76.97%   -0.02%     
==========================================
  Files         988      988              
  Lines       52371    52391      +20     
  Branches     6621     6627       +6     
==========================================
+ Hits        40324    40330       +6     
- Misses      11824    11837      +13     
- Partials      223      224       +1     
Flag Coverage Δ
javascript 71.55% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Icons/index.tsx 100.00% <ø> (ø)
...set-frontend/src/components/ListViewCard/index.tsx 100.00% <ø> (ø)
...re/components/controls/DatasourceControl/index.jsx 79.06% <ø> (ø)
...perset-frontend/src/views/CRUD/chart/ChartCard.tsx 75.60% <ø> (ø)
...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx 59.59% <ø> (ø)
...uperset-frontend/src/components/FaveStar/index.tsx 100.00% <100.00%> (ø)
...rontend/src/views/CRUD/dashboard/DashboardCard.tsx 77.77% <100.00%> (+0.50%) ⬆️
...perset-frontend/src/views/CRUD/welcome/Welcome.tsx 82.94% <100.00%> (+0.13%) ⬆️
...rc/dashboard/components/dnd/dragDroppableConfig.js 31.81% <0.00%> (-3.19%) ⬇️
...d/src/dashboard/components/gridComponents/Tabs.jsx 86.48% <0.00%> (-2.41%) ⬇️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b9b2c9...016014f. Read the comment docs.

@michael-s-molina
Copy link
Member

@pkdotson I think we should use an icon with less space between the dots to make it shorter. Like the one on Google Drive:

Screen Shot 2021-07-30 at 9 43 50 AM

@junlincc
Copy link
Member

@pkdotson I think we should use an icon with less space between the dots to make it shorter. Like the one on Google Drive:

+1, the spacing of the icon doesn't look right. do we have the icon @michael-s-molina suggested handy somewhere?

Reasons for change - menu that opens vertically should be represented by a vertical "three dots" icon versus using a horizontal icon to indicate opening a horizontal menu

@junlincc junlincc added the hold! On hold label Jul 30, 2021
@pull-request-size pull-request-size bot added size/M and removed size/S labels Jul 30, 2021
@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://34.219.63.63:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the cleanup!

@rusackas rusackas merged commit 5fd798a into apache:master Jul 30, 2021
@rusackas rusackas deleted the change-dropdownIcon branch July 30, 2021 23:02
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* change icons

* add size

* fix storybook

* fix favstar, add new icons, and others

* fix lint
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* change icons

* add size

* fix storybook

* fix favstar, add new icons, and others

* fix lint
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* change icons

* add size

* fix storybook

* fix favstar, add new icons, and others

* fix lint
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* change icons

* add size

* fix storybook

* fix favstar, add new icons, and others

* fix lint
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels hold! On hold preset-io size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants