Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: three button styles to tertiary #15978

Merged
merged 4 commits into from Jul 31, 2021
Merged

Conversation

stellalc7
Copy link
Contributor

SUMMARY

Edited 3 buttons to tertiary styling.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE
image

AFTER
Screenshot 2021-07-30 at 11 30 26
Screenshot 2021-07-30 at 11 30 23
Screenshot 2021-07-30 at 11 30 30

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@betodealmeida betodealmeida added the need:merge The PR is ready to be merged label Jul 30, 2021
@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #15978 (801bb3b) into master (cc704dd) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 801bb3b differs from pull request most recent head afad743. Consider uploading reports for the commit afad743 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #15978      +/-   ##
==========================================
- Coverage   76.98%   76.97%   -0.01%     
==========================================
  Files         988      988              
  Lines       52387    52387              
  Branches     6626     6626              
==========================================
- Hits        40329    40326       -3     
- Misses      11834    11837       +3     
  Partials      224      224              
Flag Coverage Δ
javascript 71.55% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/CRUD/CollectionTable.tsx 77.63% <ø> (ø)
...erset-frontend/src/datasource/DatasourceEditor.jsx 75.00% <ø> (ø)
superset-frontend/src/components/Select/Select.tsx 73.05% <0.00%> (-1.37%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cc704dd...afad743. Read the comment docs.

@zhaoyongjie zhaoyongjie merged commit 324ecb3 into apache:master Jul 31, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* changed margin right on warning icon to 8px

* fixed to grid units from pixels

* Changed three buttons styles to tertiary
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* changed margin right on warning icon to 8px

* fixed to grid units from pixels

* Changed three buttons styles to tertiary
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* changed margin right on warning icon to 8px

* fixed to grid units from pixels

* Changed three buttons styles to tertiary
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* changed margin right on warning icon to 8px

* fixed to grid units from pixels

* Changed three buttons styles to tertiary
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants