Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove select width #15986

Merged
merged 1 commit into from Jul 30, 2021

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Jul 30, 2021

SUMMARY

fixes styling of alert inputs

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before:
CleanShot 2021-07-30 at 11 34 50

after:
_DEV__Superset

TESTING INSTRUCTIONS

open alerts and reports

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #15986 (653a60a) into master (f1b57c0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15986   +/-   ##
=======================================
  Coverage   77.04%   77.04%           
=======================================
  Files         988      988           
  Lines       52387    52387           
  Branches     6626     6626           
=======================================
  Hits        40364    40364           
  Misses      11799    11799           
  Partials      224      224           
Flag Coverage Δ
javascript 71.55% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 62.88% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f1b57c0...653a60a. Read the comment docs.

@eschutho eschutho changed the title fix select width fix : remove select width Jul 30, 2021
@betodealmeida betodealmeida changed the title fix : remove select width fix: remove select width Jul 30, 2021
@betodealmeida betodealmeida merged commit 908db3a into apache:master Jul 30, 2021
@eschutho eschutho deleted the elizabeth/fix-select-width branch July 30, 2021 21:58
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants