Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save DB with with query #15991

Merged
merged 1 commit into from
Jul 31, 2021
Merged

Conversation

betodealmeida
Copy link
Member

SUMMARY

Databases are not saving because we're sending query as a string due to the incorrect check.

This fixes the problem, but I think we should spend some cycles improving state in the frontend. Having query be a string sometimes, and an object other times will certainly lead to more bugs.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida added the need:merge The PR is ready to be merged label Jul 30, 2021
@codecov
Copy link

codecov bot commented Jul 30, 2021

Codecov Report

Merging #15991 (aebdfb3) into master (2d61f15) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #15991   +/-   ##
=======================================
  Coverage   77.05%   77.05%           
=======================================
  Files         988      988           
  Lines       52387    52388    +1     
  Branches     6626     6626           
=======================================
+ Hits        40367    40368    +1     
  Misses      11796    11796           
  Partials      224      224           
Flag Coverage Δ
javascript 71.56% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/views/CRUD/data/database/DatabaseModal/index.tsx 44.89% <0.00%> (ø)
...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx 73.13% <0.00%> (ø)
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 95.45% <0.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d61f15...aebdfb3. Read the comment docs.

@betodealmeida betodealmeida merged commit ce6bc3b into apache:master Jul 31, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged size/XS 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants