fix(sqllab): revert #15891 to fix sqllab delay #15992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 8c7e09e.
graceguo-supercat
approved these changes
Jul 30, 2021
There was a problem hiding this comment.
LGTM.
Thanks @serenajiang investigate. I will create another PR to fix the original issue.
serenajiang
added a commit
to airbnb/superset-fork
that referenced
this pull request
Jul 31, 2021
…che#15992) This reverts commit 8c7e09e.
8 tasks
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
…che#15992) This reverts commit 8c7e09e.
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
…che#15992) This reverts commit 8c7e09e.
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…che#15992) This reverts commit 8c7e09e.
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…che#15992) This reverts commit 84da654.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 8c7e09e.
SUMMARY
#15891 caused some delays with the sql state in SQL Lab, resulting in the incorrect query being run if a user edited and ran a query quickly. Reverting this PR for now.
TESTING INSTRUCTIONS
N/A, but how I tested the bug:
I confirmed that before this change, the incorrect query was run (SELECT 1), and after this change, the correct query was run (SELECT 2).
to: @graceguo-supercat