fix(explore): highlight Run button correctly when query is stale

[suddjian]

SUMMARY

In the staleness logic, it was only looking at the changes in controls since the last render of the explore container, when actually it should look at changes since the last query.

This also fixes a number of other cases where changing the value of a control did not prompt running the query.

AFTER

Screen.Recording.2021-07-30.at.3.27.08.PM.mov

TESTING INSTRUCTIONS

Open explore, change controls around, see run button light up.

ADDITIONAL INFORMATION

• Has associated issue: fixes [explore]RUN in chart area is missing + Run in panel is not highlighted on switching viz #15973 fixes [explore][dnd] Run button doesn't appear in chart area when viz type or column value changes #15948
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #15994 (b981e27) into master (f4739f4) will increase coverage by 0.13%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master   #15994      +/-   ##
==========================================
+ Coverage   76.98%   77.11%   +0.13%     
==========================================
  Files         988      988              
  Lines       52378    53529    +1151     
  Branches     6622     7093     +471     
==========================================
+ Hits        40322    41278     +956     
- Misses      11833    12020     +187     
- Partials      223      231       +8     

Flag	Coverage Δ
hive	81.37% <ø> (ø)
javascript	71.75% <0.00%> (+0.19%)	⬆️
mysql	81.59% <ø> (-0.05%)	⬇️
postgres	81.65% <ø> (ø)
presto	81.49% <ø> (?)
python	82.18% <ø> (+0.15%)	⬆️
sqlite	81.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...nd/src/explore/components/ExploreViewContainer.jsx	2.11% <0.00%> (-0.04%)	⬇️
...d/src/dashboard/components/gridComponents/Tabs.jsx	86.50% <0.00%> (-2.39%)	⬇️
...rontend/src/views/CRUD/dashboard/DashboardCard.tsx	75.00% <0.00%> (-2.28%)	⬇️
...rc/dashboard/components/dnd/dragDroppableConfig.js	33.33% <0.00%> (-1.67%)	⬇️
...t-frontend/src/views/CRUD/welcome/SavedQueries.tsx	58.86% <0.00%> (-1.14%)	⬇️
...erset-frontend/src/SqlLab/components/SqlEditor.jsx	53.58% <0.00%> (-0.41%)	⬇️
...set-frontend/src/components/ListViewCard/index.tsx	100.00% <0.00%> (ø)
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx	95.37% <0.00%> (+0.13%)	⬆️
superset/models/core.py	89.87% <0.00%> (+0.25%)	⬆️
...nts/controls/DateFilterControl/DateFilterLabel.tsx	67.92% <0.00%> (+0.98%)	⬆️
... and 17 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4739f4...b981e27. Read the comment docs.

[rusackas]

/testenv up

[github-actions]

@rusackas Container image not yet published for this PR. Please try again when build is complete.

[github-actions]

@rusackas Ephemeral environment creation failed. Please check the Actions logs for details.

[github-actions]

@suddjian Container image not yet published for this PR. Please try again when build is complete.

[github-actions]

@suddjian Ephemeral environment creation failed. Please check the Actions logs for details.

[rusackas]

/testenv up

[github-actions]

@rusackas Ephemeral environment spinning up at http://54.68.119.214:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[rusackas]

LGTM

[jinghua-qa]

Can I test this PR with dd feature flag on? The previous reported issue is dd related

[rusackas]

/testenv up FEATURE_ENABLE_EXPLORE_DRAG_AND_DROP=true

[github-actions]

@rusackas Ephemeral environment spinning up at http://34.210.64.222:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[jinghua-qa]

LGTM!

Run.button.mov

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.

[villebro]

Awesome work!