Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): filter popover opening after removing a filter #16024

Merged
merged 1 commit into from Aug 2, 2021

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Aug 2, 2021

SUMMARY

Fixes adhoc filter popover opening when user has 2 or more filters added and removes 1 of them.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before: see linked issue
After:
https://user-images.githubusercontent.com/15073128/127877801-05e69c2c-8769-4dea-8d05-3e6f573962da.mov

TESTING INSTRUCTIONS

  1. Enable drag and drop feature flag
  2. Add 2 or more adhoc filters
  3. Remove 1 adhoc filter
  4. Verify that the popover doesn't open unnecessarily

ADDITIONAL INFORMATION

  • Has associated issue: closes [drag&drop] Removing filter option will open popover for the next  #16019
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CC @junlincc @jinghua-qa

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #16024 (a5ec877) into master (6095978) will decrease coverage by 0.10%.
The diff coverage is 56.13%.

❗ Current head a5ec877 differs from pull request most recent head 6832532. Consider uploading reports for the commit 6832532 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16024      +/-   ##
==========================================
- Coverage   76.79%   76.69%   -0.11%     
==========================================
  Files         990      995       +5     
  Lines       52517    52777     +260     
  Branches     6642     6691      +49     
==========================================
+ Hits        40330    40475     +145     
- Misses      11963    12077     +114     
- Partials      224      225       +1     
Flag Coverage Δ
javascript 71.33% <56.13%> (-0.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntend/src/dashboard/containers/DashboardHeader.jsx 100.00% <ø> (ø)
...ntend/src/explore/components/ExploreChartPanel.jsx 15.00% <ø> (ø)
...nd/src/explore/components/ExploreViewContainer.jsx 2.11% <0.00%> (ø)
superset-frontend/src/explore/reducers/index.js 0.00% <ø> (ø)
superset/reports/api.py 87.78% <ø> (ø)
superset-frontend/src/reports/actions/reports.js 21.73% <21.73%> (ø)
.../ReportModal/HeaderReportActionsDropdown/index.tsx 25.00% <25.00%> (ø)
superset-frontend/src/reports/reducers/reports.js 25.00% <25.00%> (ø)
...tend/src/explore/components/ExploreChartHeader.jsx 60.29% <54.83%> (-2.21%) ⬇️
...frontend/src/dashboard/components/Header/index.jsx 65.47% <63.33%> (-0.96%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6095978...6832532. Read the comment docs.

@kgabryje kgabryje closed this Aug 2, 2021
@kgabryje kgabryje reopened this Aug 2, 2021
@kgabryje kgabryje closed this Aug 2, 2021
@kgabryje kgabryje reopened this Aug 2, 2021
@kgabryje kgabryje closed this Aug 2, 2021
@kgabryje kgabryje reopened this Aug 2, 2021
@junlincc
Copy link
Member

junlincc commented Aug 2, 2021

/testenv up ENABLE_EXPLORE_DRAG_AND_DROP=true

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

@junlincc Ephemeral environment spinning up at http://54.190.43.140:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@kgabryje kgabryje closed this Aug 2, 2021
@kgabryje kgabryje reopened this Aug 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

Ephemeral environment shutdown and build artifacts deleted.

@kgabryje kgabryje merged commit 5917407 into apache:master Aug 2, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[drag&drop] Removing filter option will open popover for the next
4 participants