New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(explore): filter popover opening after removing a filter #16024
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16024 +/- ##
==========================================
- Coverage 76.79% 76.69% -0.11%
==========================================
Files 990 995 +5
Lines 52517 52777 +260
Branches 6642 6691 +49
==========================================
+ Hits 40330 40475 +145
- Misses 11963 12077 +114
- Partials 224 225 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up ENABLE_EXPLORE_DRAG_AND_DROP=true |
@junlincc Ephemeral environment spinning up at http://54.190.43.140:8080. Credentials are |
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Fixes adhoc filter popover opening when user has 2 or more filters added and removes 1 of them.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: see linked issue
After:
https://user-images.githubusercontent.com/15073128/127877801-05e69c2c-8769-4dea-8d05-3e6f573962da.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
CC @junlincc @jinghua-qa