Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing mulitiple metrics on pivot operator #16026

Merged
merged 2 commits into from Aug 2, 2021

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

fixes: #16023
closes: #16023

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

image

TESTING INSTRUCTIONS

UT converage

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie changed the title fix: miss mulitiple metrics on pivot operator fix: missing mulitiple metrics on pivot operator Aug 2, 2021
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix - minor non-blocking stylistic proposal

superset/utils/pandas_postprocessing.py Outdated Show resolved Hide resolved
@junlincc junlincc added rush! Requires immediate attention #bug:blocking! Blocking issues with high priority labels Aug 2, 2021
@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #16026 (8ef3051) into master (3061b6a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16026   +/-   ##
=======================================
  Coverage   76.79%   76.79%           
=======================================
  Files         990      990           
  Lines       52517    52517           
  Branches     6642     6642           
=======================================
  Hits        40330    40330           
  Misses      11963    11963           
  Partials      224      224           
Flag Coverage Δ
mysql 81.57% <100.00%> (-0.05%) ⬇️
postgres 81.63% <100.00%> (+0.04%) ⬆️
python 81.72% <100.00%> (ø)
sqlite 81.27% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/pandas_postprocessing.py 84.80% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3061b6a...8ef3051. Read the comment docs.

@junlincc
Copy link
Member

junlincc commented Aug 2, 2021

/testenv up ENABLE_EXPLORE_DRAG_AND_DROP=true

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

@junlincc Ephemeral environment spinning up at http://34.222.149.55:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@suddjian suddjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@junlincc
Copy link
Member

junlincc commented Aug 2, 2021

/testenv up FEATURE_ENABLE_EXPLORE_DRAG_AND_DROP=true

@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

@junlincc Ephemeral environment spinning up at http://54.184.39.20:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@jinghua-qa
Copy link
Member

I have tried in the test env with dd on, I can add multi metrics but DATA panel is not scrollable, and user need to click collapse/expand button in order to see the rest of the filed in DATA and for south tables

@pkdotson pkdotson merged commit 3f57ea7 into apache:master Aug 2, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Aug 2, 2021

Ephemeral environment shutdown and build artifacts deleted.

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* fix: missing mulitiple metrics on pivot operator

* code smell
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* fix: missing mulitiple metrics on pivot operator

* code smell
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* fix: missing mulitiple metrics on pivot operator

* code smell
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* fix: missing mulitiple metrics on pivot operator

* code smell
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels #bug:blocking! Blocking issues with high priority rush! Requires immediate attention size/M 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[time-series]fail to add more than one metric in time-series chart
7 participants