New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing mulitiple metrics on pivot operator #16026
Conversation
febf7ac
to
b5fb908
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix - minor non-blocking stylistic proposal
Codecov Report
@@ Coverage Diff @@
## master #16026 +/- ##
=======================================
Coverage 76.79% 76.79%
=======================================
Files 990 990
Lines 52517 52517
Branches 6642 6642
=======================================
Hits 40330 40330
Misses 11963 11963
Partials 224 224
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up ENABLE_EXPLORE_DRAG_AND_DROP=true |
@junlincc Ephemeral environment spinning up at http://34.222.149.55:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
/testenv up FEATURE_ENABLE_EXPLORE_DRAG_AND_DROP=true |
@junlincc Ephemeral environment spinning up at http://54.184.39.20:8080. Credentials are |
I have tried in the test env with dd on, I can add multi metrics but DATA panel is not scrollable, and user need to click collapse/expand button in order to see the rest of the filed in DATA and for south tables |
Ephemeral environment shutdown and build artifacts deleted. |
* fix: missing mulitiple metrics on pivot operator * code smell
* fix: missing mulitiple metrics on pivot operator * code smell
* fix: missing mulitiple metrics on pivot operator * code smell
* fix: missing mulitiple metrics on pivot operator * code smell
SUMMARY
fixes: #16023
closes: #16023
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After
TESTING INSTRUCTIONS
UT converage
ADDITIONAL INFORMATION