-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add feature flag to header bar #16031
fix: add feature flag to header bar #16031
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16031 +/- ##
==========================================
- Coverage 76.68% 76.66% -0.03%
==========================================
Files 995 995
Lines 52774 52783 +9
Branches 6691 6695 +4
==========================================
- Hits 40472 40466 -6
- Misses 12077 12092 +15
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a comment on the package upgrades.
"@superset-ui/legacy-plugin-chart-treemap": "^0.17.74", | ||
"@superset-ui/legacy-plugin-chart-world-map": "^0.17.74", | ||
"@superset-ui/legacy-preset-chart-big-number": "^0.17.74", | ||
"@superset-ui/chart-controls": "^0.17.75", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these updates intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the feature flag ALERTS_REPORT wasn't in the list which resides on superset-ui.
SUMMARY
Removes the add report icon from the header bar when feature flag is not enabled. Also prevents fetching the report list without proper access to the endpoint.
![USA_Births_Names](https://user-images.githubusercontent.com/5186919/127897983-af073cfb-1e11-4b8a-bd47-39aabe0b8bd1.png)
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
With feature flag off you should not be able to create a report from a chart or dashboard. There should be no buttons or any sort of indication that you can create a report.
ADDITIONAL INFORMATION