Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add feature flag to header bar #16031

Merged
merged 1 commit into from
Aug 2, 2021

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Aug 2, 2021

SUMMARY

Removes the add report icon from the header bar when feature flag is not enabled. Also prevents fetching the report list without proper access to the endpoint.
USA_Births_Names

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

With feature flag off you should not be able to create a report from a chart or dashboard. There should be no buttons or any sort of indication that you can create a report.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #16031 (8cfa65b) into master (5031a67) will decrease coverage by 0.02%.
The diff coverage is 17.64%.

❗ Current head 8cfa65b differs from pull request most recent head ca62b93. Consider uploading reports for the commit ca62b93 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16031      +/-   ##
==========================================
- Coverage   76.68%   76.66%   -0.03%     
==========================================
  Files         995      995              
  Lines       52774    52783       +9     
  Branches     6691     6695       +4     
==========================================
- Hits        40472    40466       -6     
- Misses      12077    12092      +15     
  Partials      225      225              
Flag Coverage Δ
javascript 71.28% <17.64%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/dashboard/components/Header/index.jsx 63.74% <14.28%> (-1.74%) ⬇️
...tend/src/explore/components/ExploreChartHeader.jsx 56.33% <14.28%> (-3.96%) ⬇️
.../ReportModal/HeaderReportActionsDropdown/index.tsx 25.71% <33.33%> (+0.71%) ⬆️
superset-frontend/src/reports/actions/reports.js 10.86% <0.00%> (-10.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5031a67...ca62b93. Read the comment docs.

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment on the package upgrades.

"@superset-ui/legacy-plugin-chart-treemap": "^0.17.74",
"@superset-ui/legacy-plugin-chart-world-map": "^0.17.74",
"@superset-ui/legacy-preset-chart-big-number": "^0.17.74",
"@superset-ui/chart-controls": "^0.17.75",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these updates intentional?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, the feature flag ALERTS_REPORT wasn't in the list which resides on superset-ui.

@eschutho eschutho merged commit e057678 into apache:master Aug 2, 2021
@eschutho eschutho deleted the elizabeth/reports-feature-flag branch August 2, 2021 17:57
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/L 🚢 1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants