Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modal is blinking when opening #16035

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes the modal blinking when opening.

@rusackas @junlincc

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

screen-recording-2021-08-02-at-32827-pm_yhNJpLZS.mp4
screen-recording-2021-08-02-at-32326-pm_4LdQY3DC.mp4

TESTING INSTRUCTIONS

See the before and after videos.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@suddjian suddjian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

noice

@codecov
Copy link

codecov bot commented Aug 2, 2021

Codecov Report

Merging #16035 (60c52e2) into master (6095978) will decrease coverage by 0.12%.
The diff coverage is 52.83%.

❗ Current head 60c52e2 differs from pull request most recent head 95f728e. Consider uploading reports for the commit 95f728e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16035      +/-   ##
==========================================
- Coverage   76.79%   76.66%   -0.13%     
==========================================
  Files         990      995       +5     
  Lines       52517    52787     +270     
  Branches     6642     6694      +52     
==========================================
+ Hits        40330    40470     +140     
- Misses      11963    12092     +129     
- Partials      224      225       +1     
Flag Coverage Δ
javascript 71.28% <52.32%> (-0.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ntend/src/dashboard/containers/DashboardHeader.jsx 100.00% <ø> (ø)
...ntend/src/explore/components/ExploreChartPanel.jsx 15.00% <ø> (ø)
...nd/src/explore/components/ExploreViewContainer.jsx 2.11% <0.00%> (ø)
superset-frontend/src/explore/reducers/index.js 0.00% <ø> (ø)
superset/reports/api.py 87.78% <ø> (ø)
superset-frontend/src/reports/actions/reports.js 10.86% <10.86%> (ø)
superset-frontend/src/reports/reducers/reports.js 25.00% <25.00%> (ø)
.../ReportModal/HeaderReportActionsDropdown/index.tsx 25.71% <25.71%> (ø)
...tend/src/explore/components/ExploreChartHeader.jsx 56.33% <47.05%> (-6.17%) ⬇️
...frontend/src/dashboard/components/Header/index.jsx 63.74% <54.54%> (-2.69%) ⬇️
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6095978...95f728e. Read the comment docs.

@michael-s-molina michael-s-molina merged commit 76a13df into apache:master Aug 2, 2021
@junlincc junlincc moved this from In Review to Done in Community Usability Bash! 🐛🐞🕷 Aug 3, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.3.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.3.0
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants