-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Replaces the select for a dropdown button in the CSS editor #16043
chore: Replaces the select for a dropdown button in the CSS editor #16043
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16043 +/- ##
==========================================
- Coverage 76.90% 76.90% -0.01%
==========================================
Files 995 995
Lines 52842 52846 +4
Branches 6709 6709
==========================================
+ Hits 40640 40641 +1
- Misses 11976 11979 +3
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up |
@michael-s-molina Ephemeral environment spinning up at http://54.218.158.159:8080. Credentials are |
Thanks for the PR, I love the new UI! Screen.Recording.2021-08-03.at.12.11.24.PM.mov |
Yes, we should open another PR to fix this bigger issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Manual tested as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thanks for the PR!
Ephemeral environment shutdown and build artifacts deleted. |
SUMMARY
Replaces the select for a dropdown button in the CSS editor. The dropdown button is more adequate to the current behavior where a user loads a template in the editor. In the previous version, the selection was not being preserved while interacting with the select and it shouldn't because the user is not editing the template but only copying its content to the editor. This was an indication that we were using the wrong component for the desired functionality.
I also changed the editor border to use the theme colors and anchored the menu to the right to display CSS templates with big names.
@junlincc @jinghua-qa @rusackas
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-08-03.at.10.51.14.AM.mov
Screen.Recording.2021-08-03.at.11.36.01.AM.mov
TESTING INSTRUCTIONS
See the videos for instructions.
ADDITIONAL INFORMATION