fix: Remove grey bar for TableElement component when metadata is empty
#16054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
approved these changes
Aug 3, 2021
Codecov Report
@@ Coverage Diff @@
## master #16054 +/- ##
==========================================
- Coverage 76.79% 76.65% -0.14%
==========================================
Files 995 995
Lines 52876 52876
Branches 6720 6720
==========================================
- Hits 40606 40532 -74
- Misses 12044 12118 +74
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
🏷 2021.31 |
…/fix-metadata-showing
hughhhh
force-pushed
the
hugh/fix-metadata-showing
branch
from
41ca9ff
to
1fed1fd
Compare
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 6, 2021
…pty (apache#16054) * create serialize json function * remove grey space with no metadata * remove console log (cherry picked from commit 11a2d4d)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
…pty (apache#16054) * create serialize json function * remove grey space with no metadata * remove console log
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
…pty (apache#16054) * create serialize json function * remove grey space with no metadata * remove console log (cherry picked from commit 11a2d4d)
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
…pty (apache#16054) * create serialize json function * remove grey space with no metadata * remove console log
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
…pty (apache#16054) * create serialize json function * remove grey space with no metadata * remove console log (cherry picked from commit 11a2d4d)
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
…pty (apache#16054) * create serialize json function * remove grey space with no metadata * remove console log (cherry picked from commit d66ec6d)
mistercrunch
added
🍒 1.3.0
🍒 1.3.1
🍒 1.3.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
A small grey bar would appear above the schema definition for gsheet table. The reason being gsheets returns empty array
[]which is causing the component to render. I've added a additional condition to check if the metadata array is empty.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION