fix: Adding report bug #16065
Merged
fix: Adding report bug #16065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16065 +/- ##
==========================================
- Coverage 76.80% 76.80% -0.01%
==========================================
Files 995 995
Lines 52866 52868 +2
Branches 6713 6714 +1
==========================================
Hits 40605 40605
- Misses 12035 12037 +2
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eschutho
approved these changes
Aug 4, 2021
AAfghahi
force-pushed
the
ch21501_alertReportBug
branch
from
53b9271
to
ceaf0a0
Compare
| @@ -60,14 +60,15 @@ export default function HeaderReportActionsDropDown({ | |||
| }; | |||
|
|
|||
| const menu = () => ( | |||
| <Menu selectable={false}> | |||
| <Menu selectable={false} css={{ width: '200px' }}> | |||
There was a problem hiding this comment.
Shouldn't this be style instead of css?
There was a problem hiding this comment.
emotion uses css, and I believe we prefer that over style which hits the dom directly.
| <Menu.Item> | ||
| {t('Email reports active')} | ||
| <Switch | ||
| data-test="toggle-active" | ||
| checked={report?.active} | ||
| onClick={(checked: boolean) => toggleActiveKey(report, checked)} | ||
| size="small" | ||
| css={{ marginLeft: '8px' }} |
There was a problem hiding this comment.
Same here?
Also, should we use grid units here?
|
@betodealmeida I'm going to merge, but feel free to comment if you think something wasn't addressed (looks like everything was). |
|
🏷 2021.31 |
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 6, 2021
* report add fix * added theme (cherry picked from commit 4359650)
villebro
pushed a commit
that referenced
this pull request
Aug 9, 2021
* report add fix * added theme (cherry picked from commit 4359650)
villebro
pushed a commit
that referenced
this pull request
Aug 10, 2021
* report add fix * added theme (cherry picked from commit 4359650)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* report add fix * added theme
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* report add fix * added theme (cherry picked from commit 4359650)
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* report add fix * added theme
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* report add fix * added theme (cherry picked from commit 4359650)
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* report add fix * added theme (cherry picked from commit ccfd16d)
mistercrunch
added
🍒 1.3.0
🍒 1.3.1
🍒 1.3.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
The reducer for the add reports feature was being sent the wrong information, this fixes it. It also adds margin left to the toggle active button.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-08-04.at.11.37.37.AM.mov
TESTING INSTRUCTIONS
Go to dashboards with ALERT_REPORTS set to true, and a role that has admin. Add a report.
ADDITIONAL INFORMATION