New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure that users viewing chart does not automatically save edit data #16077
Merged
Merged
Changes from all commits
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
fb3c19f
add last_change_at migration
pkdotson abcf200
add last_saved_by db migration
pkdotson 17dad49
finish rest of api migration
pkdotson 331d6c4
run precommit
pkdotson ce8f03c
fix name
pkdotson b0e688d
Merge branch 'master' of https://github.com/preset-io/superset into f…
pkdotson f346046
run precommitt
pkdotson ece115f
remove unused mods
pkdotson f6da782
merge migrations
pkdotson 09a40da
Update superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to…
pkdotson aec1b38
Update superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to…
pkdotson 305358e
Update superset/migrations/versions/f6196627326f_update_chart_permiss…
pkdotson cbb0272
Merge branch 'master' of https://github.com/preset-io/superset into f…
pkdotson a3a499a
Merge branch 'fix-modified-chart' of https://github.com/preset-io/sup…
pkdotson 8305945
fix test
pkdotson 4bd7780
precommit
pkdotson 8bc545a
remove print
pkdotson 116e761
fix test
pkdotson e9680ab
change test
pkdotson 51ec6e7
test commit
pkdotson 0daf523
test 2
pkdotson 9a4996c
test 3
pkdotson 8f1bb54
third time the charm
pkdotson 80f4abe
fix put req
pkdotson File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 66 additions & 0 deletions
66
superset/migrations/versions/6d20ba9ecb33_add_last_saved_at_to_slice_model.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,66 @@ | ||
# Licensed to the Apache Software Foundation (ASF) under one | ||
# or more contributor license agreements. See the NOTICE file | ||
# distributed with this work for additional information | ||
# regarding copyright ownership. The ASF licenses this file | ||
# to you under the Apache License, Version 2.0 (the | ||
# "License"); you may not use this file except in compliance | ||
# with the License. You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, | ||
# software distributed under the License is distributed on an | ||
# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
# KIND, either express or implied. See the License for the | ||
# specific language governing permissions and limitations | ||
# under the License. | ||
"""add_last_saved_at_to_slice_model | ||
|
||
Revision ID: 6d20ba9ecb33 | ||
Revises: ('ae1ed299413b', 'f6196627326f') | ||
Create Date: 2021-08-02 21:14:58.200438 | ||
|
||
""" | ||
|
||
# revision identifiers, used by Alembic. | ||
revision = "6d20ba9ecb33" | ||
down_revision = ("ae1ed299413b", "f6196627326f") | ||
|
||
import sqlalchemy as sa | ||
from alembic import op | ||
from sqlalchemy.dialects import postgresql | ||
|
||
|
||
def upgrade(): | ||
with op.batch_alter_table("slices") as batch_op: | ||
batch_op.add_column(sa.Column("last_saved_at", sa.DateTime(), nullable=True)) | ||
batch_op.add_column(sa.Column("last_saved_by_fk", sa.Integer(), nullable=True)) | ||
batch_op.create_foreign_key( | ||
"slices_last_saved_by_fk", "ab_user", ["last_saved_by_fk"], ["id"] | ||
) | ||
|
||
# now do data migration, copy values from changed_on and changed_by | ||
slices_table = sa.Table( | ||
"slices", | ||
sa.MetaData(), | ||
sa.Column("changed_on", sa.DateTime(), nullable=True), | ||
sa.Column("changed_by_fk", sa.Integer(), nullable=True), | ||
sa.Column("last_saved_at", sa.DateTime(), nullable=True), | ||
sa.Column("last_saved_by_fk", sa.Integer(), nullable=True), | ||
) | ||
conn = op.get_bind() | ||
conn.execute( | ||
slices_table.update().values( | ||
last_saved_at=slices_table.c.changed_on, | ||
last_saved_by_fk=slices_table.c.changed_by_fk, | ||
) | ||
) | ||
# ### end Alembic commands ### | ||
|
||
|
||
def downgrade(): | ||
with op.batch_alter_table("slices") as batch_op: | ||
batch_op.drop_constraint("slices_last_saved_by_fk", type_="foreignkey") | ||
batch_op.drop_column("last_saved_by_fk") | ||
batch_op.drop_column("last_saved_at") | ||
# ### end Alembic commands ### |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We probably don't need this here, but it does no harm.