-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: simplify chart permissions #16078
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16078 +/- ##
==========================================
- Coverage 76.87% 76.64% -0.23%
==========================================
Files 995 995
Lines 52876 52876
Branches 6720 6720
==========================================
- Hits 40647 40529 -118
- Misses 12003 12121 +118
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 🚢
🏷 2021.31 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, no harm done but, do we need the migration was this permission sent on a release?
(cherry picked from commit 1dbd1e9)
(cherry picked from commit 1dbd1e9)
(cherry picked from commit 1dbd1e9)
(cherry picked from commit 1dbd1e9)
(cherry picked from commit 1dbd1e9)
(cherry picked from commit a04b642)
SUMMARY
Move
cat_post_data
andcan_get_data
(inCharts
) tocan_read
.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
N/A
ADDITIONAL INFORMATION