fix: Safari is not showing scroll bars in Explore #16089

michael-s-molina · 2021-08-05T13:05:25Z

SUMMARY

Fix #16072

@junlincc @jinghua-qa @rusackas

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2021-08-05.at.9.58.19.AM.mov

Screen.Recording.2021-08-05.at.10.00.41.AM.mov

TESTING INSTRUCTIONS

See the original issue for instructions.

ADDITIONAL INFORMATION

Has associated issue:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

michael-s-molina · 2021-08-05T13:07:17Z

superset-frontend/src/explore/components/ExploreViewContainer.jsx

@@ -458,7 +459,7 @@ function ExploreViewContainer(props) {
          #app {
            flex-basis: 100%;
            overflow: hidden;
-            height: 100vh;
+            height: 100%;


The #app should account for #app-menu height. That's why I change it to percentage and set the body to 100vh.

codecov · 2021-08-05T13:31:12Z

Codecov Report

Merging #16089 (2e94795) into master (a59d458) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #16089   +/-   ##
=======================================
  Coverage   76.86%   76.86%           
=======================================
  Files         995      995           
  Lines       52876    52876           
  Branches     6720     6720           
=======================================
  Hits        40645    40645           
  Misses      12005    12005           
  Partials      226      226

Flag	Coverage Δ
javascript	`71.27% <ø> (ø)`

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...nd/src/explore/components/ExploreViewContainer.jsx	`2.11% <ø> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a59d458...2e94795. Read the comment docs.

kgabryje · 2021-08-05T15:25:25Z

/testenv up

github-actions · 2021-08-05T15:46:56Z

@kgabryje Container image not yet published for this PR. Please try again when build is complete.

github-actions · 2021-08-05T15:46:57Z

@kgabryje Ephemeral environment creation failed. Please check the Actions logs for details.

junlincc · 2021-08-05T18:31:03Z

/testenv up

github-actions · 2021-08-05T18:40:51Z

@junlincc Ephemeral environment spinning up at http://54.191.154.174:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

junlincc · 2021-08-05T19:19:23Z

thank you so much for the quick fix!

Screen.Recording.2021-08-05.at.9.18.26.AM.mov

looks like the top padding is missing? above the button @michael-s-molina

junlincc

padding above run buttons is missing 😅

michael-s-molina · 2021-08-05T21:02:13Z

@junlincc I wasn't able to reproduce this behavior in the test env. Tested in Safari and Chrome. 🤔

Screen.Recording.2021-08-05.at.5.59.18.PM.mov

kgabryje · 2021-08-06T16:22:09Z

@junlincc I'm not able to reproduce as well

rusackas

LGTM!

michael-s-molina · 2021-08-10T10:51:57Z

@junlincc Can you unblock?

Reviewed by other members as not reproducible

github-actions · 2021-08-10T13:42:18Z

Ephemeral environment shutdown and build artifacts deleted.

rosemarie-chiu · 2021-08-10T22:05:53Z

🏷 2021.31

(cherry picked from commit 273ab3d)

(cherry picked from commit df16bd3)

fix: Safari is not showing scroll bars in Explore

2e94795

michael-s-molina requested review from suddjian, nytai, pkdotson and geido August 5, 2021 13:05

superset-github-bot bot added the Turing label Aug 5, 2021

pull-request-size bot added the size/XS label Aug 5, 2021

michael-s-molina commented Aug 5, 2021

View reviewed changes

michael-s-molina requested a review from kgabryje August 5, 2021 13:36

junlincc added the rush! Requires immediate attention label Aug 5, 2021

junlincc added hold:testing! On hold for testing and removed rush! Requires immediate attention labels Aug 5, 2021

junlincc previously requested changes Aug 5, 2021

View reviewed changes

michael-s-molina requested a review from junlincc August 9, 2021 11:19

junlincc removed the hold:testing! On hold for testing label Aug 9, 2021

rusackas approved these changes Aug 9, 2021

View reviewed changes

michael-s-molina merged commit 273ab3d into apache:master Aug 10, 2021

superset-github-bot bot added the preset:2021.31 label Aug 10, 2021

stevenuray pushed a commit to preset-io/superset that referenced this pull request Aug 11, 2021

fix: Safari is not showing scroll bars in Explore (apache#16089)

baeac9d

(cherry picked from commit 273ab3d)

villebro added the v1.3 label Aug 12, 2021

villebro pushed a commit that referenced this pull request Aug 16, 2021

fix: Safari is not showing scroll bars in Explore (#16089)

2d59be3

(cherry picked from commit 273ab3d)

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021

fix: Safari is not showing scroll bars in Explore (apache#16089)

a2543af

cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021

fix: Safari is not showing scroll bars in Explore (apache#16089)

8596335

(cherry picked from commit 273ab3d)

QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021

fix: Safari is not showing scroll bars in Explore (apache#16089)

7bc054c

QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021

fix: Safari is not showing scroll bars in Explore (apache#16089)

0b4dfa4

(cherry picked from commit 273ab3d)

syazshafei mentioned this pull request Jan 19, 2022

Dataset and Chart options vertical scroll not working #18047

Closed

cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024

fix: Safari is not showing scroll bars in Explore (apache#16089)

59fd59e

(cherry picked from commit df16bd3)

mistercrunch added 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: Safari is not showing scroll bars in Explore #16089

fix: Safari is not showing scroll bars in Explore #16089

michael-s-molina commented Aug 5, 2021

michael-s-molina Aug 5, 2021

codecov bot commented Aug 5, 2021

kgabryje commented Aug 5, 2021

github-actions bot commented Aug 5, 2021

github-actions bot commented Aug 5, 2021

junlincc commented Aug 5, 2021

github-actions bot commented Aug 5, 2021

junlincc commented Aug 5, 2021 •

edited

Loading

junlincc left a comment

michael-s-molina commented Aug 5, 2021

kgabryje commented Aug 6, 2021

rusackas left a comment

michael-s-molina commented Aug 10, 2021

github-actions bot commented Aug 10, 2021

rosemarie-chiu commented Aug 10, 2021

fix: Safari is not showing scroll bars in Explore #16089

fix: Safari is not showing scroll bars in Explore #16089

Conversation

michael-s-molina commented Aug 5, 2021

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

michael-s-molina Aug 5, 2021

Choose a reason for hiding this comment

codecov bot commented Aug 5, 2021

Codecov Report

kgabryje commented Aug 5, 2021

github-actions bot commented Aug 5, 2021

github-actions bot commented Aug 5, 2021

junlincc commented Aug 5, 2021

github-actions bot commented Aug 5, 2021

junlincc commented Aug 5, 2021 • edited Loading

junlincc left a comment

Choose a reason for hiding this comment

michael-s-molina commented Aug 5, 2021

kgabryje commented Aug 6, 2021

rusackas left a comment

Choose a reason for hiding this comment

michael-s-molina commented Aug 10, 2021

github-actions bot commented Aug 10, 2021

rosemarie-chiu commented Aug 10, 2021

junlincc commented Aug 5, 2021 •

edited

Loading