New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: load tabbed dash only for tests #16091
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16091 +/- ##
==========================================
- Coverage 76.87% 76.64% -0.23%
==========================================
Files 995 995
Lines 52876 52877 +1
Branches 6720 6720
==========================================
- Hits 40647 40529 -118
- Misses 12003 12122 +119
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
(cherry picked from commit b72fd7b)
(cherry picked from commit b72fd7b)
(cherry picked from commit b72fd7b)
(cherry picked from commit b72fd7b)
(cherry picked from commit b72fd7b)
(cherry picked from commit 26a992e)
SUMMARY
The "tabbed dashboard" has no real content, but is the only dashboard where we tests tabs.
This PR removes the dashboard from a regular
load-examples
, keeping it only for tests.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
Run
superset load-examples
and check that the "tabbed dashboard" is no longer there.Run cypress tests and check that
cypress/integration/dashboard/tabs.test.ts
ran.ADDITIONAL INFORMATION