Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load tabbed dash only for tests #16091

Merged
merged 1 commit into from Aug 5, 2021

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Aug 5, 2021

SUMMARY

The "tabbed dashboard" has no real content, but is the only dashboard where we tests tabs.

This PR removes the dashboard from a regular load-examples, keeping it only for tests.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

Run superset load-examples and check that the "tabbed dashboard" is no longer there.
Run cypress tests and check that cypress/integration/dashboard/tabs.test.ts ran.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida requested review from abhioncbr, eschutho and hughhhh and removed request for abhioncbr August 5, 2021 16:13
@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #16091 (845405c) into master (11a2d4d) will decrease coverage by 0.22%.
The diff coverage is 0.00%.

❗ Current head 845405c differs from pull request most recent head e1afde0. Consider uploading reports for the commit e1afde0 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16091      +/-   ##
==========================================
- Coverage   76.87%   76.64%   -0.23%     
==========================================
  Files         995      995              
  Lines       52876    52877       +1     
  Branches     6720     6720              
==========================================
- Hits        40647    40529     -118     
- Misses      12003    12122     +119     
  Partials      226      226              
Flag Coverage Δ
hive ?
mysql 81.55% <0.00%> (-0.05%) ⬇️
postgres 81.61% <0.00%> (-0.01%) ⬇️
presto ?
python 81.70% <0.00%> (-0.44%) ⬇️
sqlite 81.21% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ponents/controls/VizTypeControl/VizTypeGallery.tsx 94.83% <ø> (ø)
...-frontend/src/visualizations/presets/MainPreset.js 0.00% <ø> (ø)
superset/cli.py 51.34% <0.00%> (-0.13%) ⬇️
superset/constants.py 100.00% <ø> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.80% <0.00%> (-16.87%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-6.91%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/connectors/sqla/models.py 88.08% <0.00%> (-1.67%) ⬇️
superset/db_engine_specs/base.py 87.98% <0.00%> (-0.39%) ⬇️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 11a2d4d...e1afde0. Read the comment docs.

@betodealmeida betodealmeida added preset:2021.31 need:merge The PR is ready to be merged labels Aug 5, 2021
@betodealmeida betodealmeida merged commit b72fd7b into apache:master Aug 5, 2021
henryyeh pushed a commit to preset-io/superset that referenced this pull request Aug 6, 2021
villebro pushed a commit that referenced this pull request Aug 9, 2021
@villebro villebro added the v1.3 label Aug 9, 2021
villebro pushed a commit that referenced this pull request Aug 10, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:merge The PR is ready to be merged preset:2021.31 size/XS v1.3 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants