Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Calendar color change #16093

Merged
merged 1 commit into from
Aug 5, 2021

Conversation

AAfghahi
Copy link
Member

@AAfghahi AAfghahi commented Aug 5, 2021

SUMMARY

This changes the Calendar button on the chart page to be consistent with the one on the dashboard page.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Chart:
Screen Shot 2021-08-05 at 12 32 31 PM
Dashboard:
Screen Shot 2021-08-05 at 12 13 53 PM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #16093 (1fce2b7) into master (a59d458) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16093      +/-   ##
==========================================
- Coverage   76.86%   76.86%   -0.01%     
==========================================
  Files         995      995              
  Lines       52876    52877       +1     
  Branches     6720     6720              
==========================================
  Hits        40645    40645              
- Misses      12005    12006       +1     
  Partials      226      226              
Flag Coverage Δ
javascript 71.26% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...tend/src/explore/components/ExploreChartHeader.jsx 55.55% <0.00%> (-0.79%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a59d458...1fce2b7. Read the comment docs.

@eschutho eschutho merged commit e6274e0 into apache:master Aug 5, 2021
@eschutho eschutho deleted the ch21529_changeCalendarColor branch August 5, 2021 17:38
@rosemarie-chiu
Copy link
Contributor

🏷 2021.31

henryyeh pushed a commit to preset-io/superset that referenced this pull request Aug 6, 2021
(cherry picked from commit e6274e0)
villebro pushed a commit that referenced this pull request Aug 9, 2021
(cherry picked from commit e6274e0)
@villebro villebro added the v1.3 label Aug 9, 2021
villebro pushed a commit that referenced this pull request Aug 10, 2021
(cherry picked from commit e6274e0)
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
(cherry picked from commit e6274e0)
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
(cherry picked from commit e6274e0)
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
(cherry picked from commit 0efc6ce)
@mistercrunch mistercrunch added 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.31 size/XS v1.3 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants