fix: Multiple dashboard refresh triggers for the same session #16094
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16094 +/- ##
==========================================
- Coverage 76.88% 76.85% -0.04%
==========================================
Files 995 995
Lines 52864 52887 +23
Branches 6712 6721 +9
==========================================
- Hits 40646 40645 -1
- Misses 11992 12017 +25
+ Partials 226 225 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
your BEFORE AFTER videos crack me up LOL! ∞∞∞∞∞∞∞ .thanks for the fix! LGTM |
| @@ -366,7 +366,8 @@ export const hydrateDashboard = (dashboardData, chartData) => ( | |||
| directPathLastUpdated: Date.now(), | |||
| focusedFilterField: null, | |||
| expandedSlices: metadata?.expanded_slices || {}, | |||
| refreshFrequency: metadata?.refresh_frequency || 0, | |||
| refreshFrequency: | |||
| metadata?.refresh_frequency || dashboardState.refreshFrequency || 0, | |||
There was a problem hiding this comment.
I'm not sure about the || dashboardState.refreshFrequency here. If you start at dashboard A (which has refresh), navigate to the dashboard list and then go to dashboard B (which has no refresh) wouldn't B inherit the refresh frequency from A?
There was a problem hiding this comment.
I wish we had a redux store where these things were keyed by dashboard id
There was a problem hiding this comment.
@suddjian You are totally right! I tested and B is inheriting from A. I'll try to fix it.
|
/testenv up |
|
@suddjian Ephemeral environment spinning up at http://34.220.92.135:8080. Credentials are |
michael-s-molina
force-pushed
the
fix-dashboard-auto-refresh
branch
from
84e48bc
to
e9af0c1
Compare
|
@suddjian @junlincc Since our redux store is not indexed by the dashboard, and changing that can potentially break other functions, I decided to cancel the timers as soon as the user leaves the dashboard. Is not the ideal solution, but it's better than the current state, where the timers are being duplicated. |
|
Ephemeral environment shutdown and build artifacts deleted. |
|
🏷 2021.31 |
(cherry picked from commit 07f3399)
mistercrunch
added
🍒 1.3.0
🍒 1.3.1
🍒 1.3.2
🏷️ bot
SUMMARY
Fix: Multiple dashboard refresh triggers for the same session.
@junlincc @jinghua-qa
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
screen-recording-2021-08-05-at-22337-pm_rshjFmrR.mp4
screen-recording-2021-08-05-at-21917-pm_umGDz3Fq.mp4
TESTING INSTRUCTIONS
Check the videos for instructions.
ADDITIONAL INFORMATION