-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: move watermark to about section #16097
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16097 +/- ##
==========================================
- Coverage 76.79% 76.76% -0.03%
==========================================
Files 995 995
Lines 52878 52879 +1
Branches 6720 6721 +1
==========================================
- Hits 40606 40595 -11
- Misses 12046 12058 +12
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Thanks @nytai for tackling this! To be clear the longer term vision is to give more room to the "Powered by Apache Superset" under a sub menu in the Preset logo (top-left), with a nice biggish Superset logo. This along with more resources in a large sub-menu. This has not been fully designed yet, but ideas included things like a "preset workspace picker", "invite friends!" and other actions |
🏷 2021.31 |
(cherry picked from commit b80f018)
(cherry picked from commit b80f018)
(cherry picked from commit b80f018)
(cherry picked from commit b80f018)
(cherry picked from commit b80f018)
(cherry picked from commit 3787677)
SUMMARY
Moving the "Powered by Apache Superset" watermark to the About section in the menu
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
![Screen Shot 2021-08-05 at 3 37 19 PM](https://user-images.githubusercontent.com/10255196/128430658-62805fc2-22c5-47f8-823b-14f5e71e48fe.png)
TESTING INSTRUCTIONS
👀
ADDITIONAL INFORMATION