Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move watermark to about section #16097

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

nytai
Copy link
Member

@nytai nytai commented Aug 5, 2021

SUMMARY

Moving the "Powered by Apache Superset" watermark to the About section in the menu

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After:
Screen Shot 2021-08-05 at 3 37 19 PM

TESTING INSTRUCTIONS

👀

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 5, 2021

Codecov Report

Merging #16097 (5944ef0) into master (b72fd7b) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16097      +/-   ##
==========================================
- Coverage   76.79%   76.76%   -0.03%     
==========================================
  Files         995      995              
  Lines       52878    52879       +1     
  Branches     6720     6721       +1     
==========================================
- Hits        40606    40595      -11     
- Misses      12046    12058      +12     
  Partials      226      226              
Flag Coverage Δ
javascript 71.22% <50.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-frontend/src/components/Menu/MenuRight.tsx 92.15% <50.00%> (+1.59%) ⬆️
...ontrols/DndColumnSelectControl/DndColumnSelect.tsx 46.42% <0.00%> (-14.69%) ⬇️
...ols/DndColumnSelectControl/utils/optionSelector.ts 34.61% <0.00%> (-11.54%) ⬇️
superset-frontend/src/dashboard/actions/hydrate.js 1.69% <0.00%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b72fd7b...5944ef0. Read the comment docs.

@nytai nytai closed this Aug 6, 2021
@nytai nytai deleted the tai/fix-watermark branch August 6, 2021 01:03
@nytai nytai restored the tai/fix-watermark branch August 6, 2021 02:49
@nytai nytai reopened this Aug 6, 2021
@mistercrunch
Copy link
Member

Thanks @nytai for tackling this!

To be clear the longer term vision is to give more room to the "Powered by Apache Superset" under a sub menu in the Preset logo (top-left), with a nice biggish Superset logo. This along with more resources in a large sub-menu. This has not been fully designed yet, but ideas included things like a "preset workspace picker", "invite friends!" and other actions

@nytai nytai merged commit b80f018 into apache:master Aug 6, 2021
@nytai nytai deleted the tai/fix-watermark branch August 6, 2021 12:48
@rosemarie-chiu
Copy link
Contributor

🏷 2021.31

villebro pushed a commit that referenced this pull request Aug 9, 2021
@villebro villebro added the v1.3 label Aug 9, 2021
villebro pushed a commit that referenced this pull request Aug 10, 2021
stevenuray pushed a commit to preset-io/superset that referenced this pull request Aug 11, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.31 preset-io size/S v1.3 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants