fix: migrate_roles

[betodealmeida]

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #16098 (d6c388c) into master (b72fd7b) will decrease coverage by 0.14%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #16098      +/-   ##
==========================================
- Coverage   76.79%   76.64%   -0.15%     
==========================================
  Files         995      995              
  Lines       52878    52880       +2     
  Branches     6720     6720              
==========================================
- Hits        40606    40530      -76     
- Misses      12046    12124      +78     
  Partials      226      226              

Flag	Coverage Δ
hive	?
mysql	81.59% <50.00%> (+0.03%)	⬆️
postgres	81.61% <50.00%> (-0.01%)	⬇️
python	81.70% <50.00%> (-0.29%)	⬇️
sqlite	81.25% <50.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/migrations/shared/security_converge.py	86.36% <50.00%> (-0.56%)	⬇️
superset/db_engines/hive.py	0.00% <0.00%> (-82.15%)	⬇️
superset/db_engine_specs/hive.py	69.80% <0.00%> (-16.87%)	⬇️
superset/views/database/mixins.py	81.03% <0.00%> (-1.73%)	⬇️
superset/db_engine_specs/presto.py	83.47% <0.00%> (-1.05%)	⬇️
superset/db_engine_specs/base.py	87.98% <0.00%> (-0.39%)	⬇️
superset/connectors/sqla/models.py	88.08% <0.00%> (-0.24%)	⬇️
superset/utils/core.py	88.09% <0.00%> (-0.13%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b72fd7b...d6c388c. Read the comment docs.

[dpgaspar]

I think that this happens because the new permissions need to exist on the DB first, here: https://github.com/apache/superset/blob/master/superset/migrations/versions/f6196627326f_update_chart_permissions.py#L54. Heres an example: https://github.com/apache/superset/blob/master/superset/migrations/versions/42b4c9e01447_security_converge_databases.py#L61

[henryyeh]

🏷️ 2021.31