-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sticky state to tables and loadingcards state. #16102
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16102 +/- ##
==========================================
- Coverage 76.87% 76.83% -0.04%
==========================================
Files 995 995
Lines 52876 52916 +40
Branches 6720 6734 +14
==========================================
+ Hits 40647 40660 +13
- Misses 12003 12031 +28
+ Partials 226 225 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
/testenv up FEATURE_THUMBNAILS=true |
@pkdotson Ephemeral environment spinning up at http://35.164.170.6:8080. Credentials are |
@pkdotson When the panels are collapsed and you refresh, it first renders all the cards and then collapses. Can we make it not render any panels for collapsed cards? |
/testenv up FEATURE_THUMBNAILS=true |
@pkdotson Ephemeral environment spinning up at http://34.217.57.236:8080. Credentials are |
Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
Looking good! And approving! I made one more comment about a const, and also noticed this little issue, which could be tackled in a separate PR or this one (since the issue is ALMOST fixed by this PR): As you can barely see in this GIF, when changing tabs, the loading state looks great, but goes higher up very briefly because the row containing the tabs very briefly disappears from the layout when switching tabs. If that disappearance can be solved, so it just changes without "blinking" we should be in awesome shape! Again, maybe this is a follow-up PR and not a blocker for this one. CC @junlincc for any ticketing/prioritization awareness. |
Ephemeral environment shutdown and build artifacts deleted. |
🏷 2021.31 |
* initial feat commit * fix chart and dash rendering onload * Update superset-frontend/src/views/CRUD/welcome/Welcome.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * fix jumpyness and add const Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> (cherry picked from commit a702487)
* initial feat commit * fix chart and dash rendering onload * Update superset-frontend/src/views/CRUD/welcome/Welcome.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * fix jumpyness and add const Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> (cherry picked from commit a702487)
* initial feat commit * fix chart and dash rendering onload * Update superset-frontend/src/views/CRUD/welcome/Welcome.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * fix jumpyness and add const Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* initial feat commit * fix chart and dash rendering onload * Update superset-frontend/src/views/CRUD/welcome/Welcome.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * fix jumpyness and add const Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> (cherry picked from commit a702487)
* initial feat commit * fix chart and dash rendering onload * Update superset-frontend/src/views/CRUD/welcome/Welcome.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * fix jumpyness and add const Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com>
* initial feat commit * fix chart and dash rendering onload * Update superset-frontend/src/views/CRUD/welcome/Welcome.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * fix jumpyness and add const Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> (cherry picked from commit a702487)
* initial feat commit * fix chart and dash rendering onload * Update superset-frontend/src/views/CRUD/welcome/Welcome.tsx Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> * fix jumpyness and add const Co-authored-by: Michael S. Molina <70410625+michael-s-molina@users.noreply.github.com> (cherry picked from commit 8025068)
SUMMARY
This pr enhances homepage with sticky states for the tables and add loadingcards states and fix padding issues on minified cards.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Screen.Recording.2021-08-05.at.6.00.49.PM.mov
TESTING INSTRUCTIONS
Go to homepage and and clip collapse tables to ensure they stick.
ADDITIONAL INFORMATION