-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(explore): change dnd placeholders #16116
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, since it's only changing the placeholder, nothing technical. approving.
Codecov Report
@@ Coverage Diff @@
## master #16116 +/- ##
=======================================
Coverage 76.84% 76.85%
=======================================
Files 995 995
Lines 52886 52887 +1
Branches 6721 6722 +1
=======================================
+ Hits 40640 40644 +4
+ Misses 12021 12018 -3
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
🏷 2021.31 |
* chore(explore): change dnd placeholders * Fix tests and lint (cherry picked from commit 6ac4f4e)
* chore(explore): change dnd placeholders * Fix tests and lint (cherry picked from commit 6ac4f4e)
* chore(explore): change dnd placeholders * Fix tests and lint
* chore(explore): change dnd placeholders * Fix tests and lint (cherry picked from commit 6ac4f4e)
* chore(explore): change dnd placeholders * Fix tests and lint
* chore(explore): change dnd placeholders * Fix tests and lint (cherry picked from commit 6ac4f4e)
* chore(explore): change dnd placeholders * Fix tests and lint (cherry picked from commit 1f720b6)
SUMMARY
Add "here" suffix to drag and drop controls placeholders.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
![image](https://user-images.githubusercontent.com/15073128/128524674-374ef50b-0d88-41a2-bfbd-d8e314aba3fe.png)
After:
![image](https://user-images.githubusercontent.com/15073128/128524429-dffc66c3-059f-4826-a16a-3f2150247161.png)
TESTING INSTRUCTIONS
Enable dnd and verify that all controls placeholders have "here" suffix
ADDITIONAL INFORMATION
CC @junlincc @srinify