Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(explore): change dnd placeholders #16116

Merged
merged 2 commits into from
Aug 9, 2021

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Aug 6, 2021

SUMMARY

Add "here" suffix to drag and drop controls placeholders.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

Enable dnd and verify that all controls placeholders have "here" suffix

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

CC @junlincc @srinify

@junlincc junlincc added the explore:drag&drop Related to drag&drop in Explore label Aug 6, 2021
Copy link
Member

@junlincc junlincc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, since it's only changing the placeholder, nothing technical. approving.

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Aug 9, 2021
@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #16116 (d7b176d) into master (b80f018) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16116   +/-   ##
=======================================
  Coverage   76.84%   76.85%           
=======================================
  Files         995      995           
  Lines       52886    52887    +1     
  Branches     6721     6722    +1     
=======================================
+ Hits        40640    40644    +4     
+ Misses      12021    12018    -3     
  Partials      225      225           
Flag Coverage Δ
javascript 71.23% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontrols/DndColumnSelectControl/DndColumnSelect.tsx 47.36% <ø> (+0.93%) ⬆️
...ontrols/DndColumnSelectControl/DndFilterSelect.tsx 45.07% <ø> (ø)
...ontrols/DndColumnSelectControl/DndMetricSelect.tsx 42.06% <ø> (ø)
...controls/DndColumnSelectControl/DndSelectLabel.tsx 85.00% <100.00%> (ø)
...ols/DndColumnSelectControl/utils/optionSelector.ts 46.15% <0.00%> (+11.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b80f018...d7b176d. Read the comment docs.

@kgabryje kgabryje merged commit 6ac4f4e into apache:master Aug 9, 2021
@rosemarie-chiu
Copy link
Contributor

🏷 2021.31

@villebro villebro added the v1.3 label Aug 9, 2021
villebro pushed a commit that referenced this pull request Aug 10, 2021
* chore(explore): change dnd placeholders

* Fix tests and lint

(cherry picked from commit 6ac4f4e)
stevenuray pushed a commit to preset-io/superset that referenced this pull request Aug 11, 2021
* chore(explore): change dnd placeholders

* Fix tests and lint

(cherry picked from commit 6ac4f4e)
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* chore(explore): change dnd placeholders

* Fix tests and lint
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* chore(explore): change dnd placeholders

* Fix tests and lint

(cherry picked from commit 6ac4f4e)
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
* chore(explore): change dnd placeholders

* Fix tests and lint
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* chore(explore): change dnd placeholders

* Fix tests and lint

(cherry picked from commit 6ac4f4e)
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* chore(explore): change dnd placeholders

* Fix tests and lint

(cherry picked from commit 1f720b6)
@mistercrunch mistercrunch added 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels explore:drag&drop Related to drag&drop in Explore preset:2021.31 size/S v1.3 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants