fix: change Alert Permissions #16118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAfghahi
force-pushed
the
ch21572_alertPermissions
branch
from
5b8c2fc
to
f4c5326
Compare
Codecov Report
@@ Coverage Diff @@
## master #16118 +/- ##
==========================================
- Coverage 76.84% 76.84% -0.01%
==========================================
Files 995 995
Lines 52886 52885 -1
Branches 6721 6721
==========================================
- Hits 40640 40638 -2
- Misses 12021 12022 +1
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@eschutho For public users (which is the starter tier) are we turning off their Alerts_Reports feature flag or is that permissions based? |
eschutho
approved these changes
Aug 9, 2021
|
🏷 2021.31 |
villebro
pushed a commit
that referenced
this pull request
Aug 10, 2021
* added google alert * reworked permissions (cherry picked from commit 606a7bf)
stevenuray
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 11, 2021
* added google alert * reworked permissions (cherry picked from commit 606a7bf)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* added google alert * reworked permissions
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* added google alert * reworked permissions (cherry picked from commit 606a7bf)
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* added google alert * reworked permissions
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* added google alert * reworked permissions (cherry picked from commit 606a7bf)
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* added google alert * reworked permissions (cherry picked from commit 35e7a32)
mistercrunch
added
🍒 1.3.0
🍒 1.3.1
🍒 1.3.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR adjusts who can see the new dashboard and chart subscribe Icon. Previously it was based on who can add a report, but now it is based on if you have access to alerts and reports in the settings menu.
While looking through this, I noticed that a limited/gamma user does have permissions to add, view, and has menu access to Alerts and Reports. Maybe this is an oversight and we need to adjust the permissions for Gamma users?
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Admin User:
Gamma:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION