feat: better errors for report in charts and dashboard #16131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AAfghahi
force-pushed
the
ch21753_betterErrors
branch
from
b9054a7
to
0767844
Compare
AAfghahi
force-pushed
the
ch21753_betterErrors
branch
from
0767844
to
dfb42c9
Compare
Codecov Report
@@ Coverage Diff @@
## master #16131 +/- ##
==========================================
- Coverage 76.84% 76.83% -0.01%
==========================================
Files 995 995
Lines 52884 52890 +6
Branches 6721 6722 +1
==========================================
+ Hits 40638 40639 +1
- Misses 12021 12026 +5
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eschutho
approved these changes
Aug 9, 2021
|
🏷 2021.31 |
villebro
pushed a commit
that referenced
this pull request
Aug 10, 2021
* added google alert * better errors and report actions (cherry picked from commit 5ce3883)
stevenuray
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 11, 2021
* added google alert * better errors and report actions (cherry picked from commit 5ce3883)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* added google alert * better errors and report actions
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* added google alert * better errors and report actions (cherry picked from commit 5ce3883)
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* added google alert * better errors and report actions
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* added google alert * better errors and report actions (cherry picked from commit 5ce3883)
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* added google alert * better errors and report actions (cherry picked from commit d9517a1)
mistercrunch
added
🍒 1.3.0
🍒 1.3.1
🍒 1.3.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This creates a better error message when a report is failed to create in dashboard or chart.
It also adds makes the edit modal have a save button.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION