Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: virtual dataset wont work #16132

Merged
merged 1 commit into from Aug 7, 2021

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Aug 7, 2021

SUMMARY

closes: #16124
fix that dataset modal is unable to save settings and virtual SQL.
@graceguo-supercat @yousoph @junlincc

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

fix_virtual_dataset.mov

TESTING INSTRUCTIONS

  1. create a virtual dataset
  2. open explore page and use virtual dataset
  3. change virtual dataset SQL, ensure that SQL is modified correctly
  4. change dataset settings, ensure that settings are modified correctly

ADDITIONAL INFORMATION

  • Has associated issue: [table editor] Change virtual dataset won't work #16124
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 7, 2021

Codecov Report

Merging #16132 (a7aef31) into master (85ae8e3) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16132   +/-   ##
=======================================
  Coverage   76.84%   76.84%           
=======================================
  Files         995      995           
  Lines       52884    52884           
  Branches     6721     6721           
=======================================
  Hits        40638    40638           
  Misses      12021    12021           
  Partials      225      225           
Flag Coverage Δ
javascript 71.23% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset-frontend/src/datasource/DatasourceEditor.jsx 74.25% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 85ae8e3...a7aef31. Read the comment docs.

Copy link

@graceguo-supercat graceguo-supercat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the quick fix!

@zhaoyongjie zhaoyongjie merged commit 3bbcc30 into apache:master Aug 7, 2021
@villebro villebro added the v1.3 label Aug 9, 2021
villebro pushed a commit that referenced this pull request Aug 10, 2021
stevenuray pushed a commit to preset-io/superset that referenced this pull request Aug 11, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.31 size/XS v1.3 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[table editor] Change virtual dataset won't work
5 participants