New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: virtual dataset wont work #16132
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16132 +/- ##
=======================================
Coverage 76.84% 76.84%
=======================================
Files 995 995
Lines 52884 52884
Branches 6721 6721
=======================================
Hits 40638 40638
Misses 12021 12021
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! thanks for the quick fix!
(cherry picked from commit 3bbcc30)
(cherry picked from commit 3bbcc30)
(cherry picked from commit 3bbcc30)
(cherry picked from commit 3bbcc30)
(cherry picked from commit 5c244dc)
SUMMARY
closes: #16124
fix that dataset modal is unable to save settings and virtual SQL.
@graceguo-supercat @yousoph @junlincc
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After
fix_virtual_dataset.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION