Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: test_import_2_slices_for_same_table #16137

Merged
merged 1 commit into from
Aug 9, 2021

Conversation

betodealmeida
Copy link
Member

SUMMARY

Tentative fix for a test that's failing without a good stacktrace.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida changed the title fix: test fix: test_import_2_slices_for_same_table Aug 8, 2021
@codecov
Copy link

codecov bot commented Aug 8, 2021

Codecov Report

Merging #16137 (7908405) into master (3bbcc30) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16137   +/-   ##
=======================================
  Coverage   76.83%   76.84%           
=======================================
  Files         995      995           
  Lines       52884    52884           
  Branches     6721     6721           
=======================================
+ Hits        40636    40638    +2     
+ Misses      12023    12021    -2     
  Partials      225      225           
Flag Coverage Δ
hive 81.32% <ø> (+0.04%) ⬆️
mysql 81.54% <ø> (-0.05%) ⬇️
postgres 81.60% <ø> (ø)
presto 81.40% <ø> (-0.04%) ⬇️
python 82.12% <ø> (+<0.01%) ⬆️
sqlite 81.20% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/presto.py 90.37% <0.00%> (+0.41%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bbcc30...7908405. Read the comment docs.

@betodealmeida betodealmeida merged commit ddb5005 into apache:master Aug 9, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants