Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Hide Safari default tooltip #16145

Merged
merged 1 commit into from
Aug 10, 2021
Merged

fix: Hide Safari default tooltip #16145

merged 1 commit into from
Aug 10, 2021

Conversation

geido
Copy link
Member

@geido geido commented Aug 9, 2021

SUMMARY

This PR implements a small hack to prevent Safari from showing its default tooltip when a text is truncated and a custom Antdesign tooltip is already present.

RELATED PR ON SUPERSET-UI

apache-superset/superset-ui#1283

BEFORE

Screen Shot 2021-08-09 at 16 50 59

AFTER

Screen Shot 2021-08-09 at 16 48 47

ADDITIONAL INFORMATION

@codecov
Copy link

codecov bot commented Aug 9, 2021

Codecov Report

Merging #16145 (e7c0bd8) into master (423ff50) will increase coverage by 0.00%.
The diff coverage is 81.48%.

❗ Current head e7c0bd8 differs from pull request most recent head f7586eb. Consider uploading reports for the commit f7586eb to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16145   +/-   ##
=======================================
  Coverage   76.83%   76.84%           
=======================================
  Files         995      995           
  Lines       52884    52885    +1     
  Branches     6721     6721           
=======================================
+ Hits        40636    40640    +4     
+ Misses      12023    12020    -3     
  Partials      225      225           
Flag Coverage Δ
javascript 71.24% <94.11%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontrols/DndColumnSelectControl/DndColumnSelect.tsx 46.42% <ø> (ø)
superset/charts/schemas.py 100.00% <ø> (ø)
superset/dashboards/schemas.py 99.37% <ø> (-0.01%) ⬇️
superset/models/dashboard.py 76.69% <ø> (-0.30%) ⬇️
...uperset-frontend/src/components/Menu/MenuRight.tsx 92.15% <50.00%> (+1.59%) ⬆️
superset/utils/memoized.py 86.11% <55.55%> (-7.83%) ⬇️
superset-frontend/src/components/Select/Select.tsx 74.66% <100.00%> (+1.35%) ⬆️
superset-frontend/src/components/Tooltip/index.tsx 100.00% <100.00%> (ø)
...ntend/src/dashboard/components/CssEditor/index.jsx 96.42% <100.00%> (+0.59%) ⬆️
.../src/dashboard/components/RefreshIntervalModal.tsx 89.47% <100.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 423ff50...f7586eb. Read the comment docs.

@geido
Copy link
Member Author

geido commented Aug 9, 2021

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Aug 9, 2021

@geido Ephemeral environment spinning up at http://34.214.104.103:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@pkdotson pkdotson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix!

@rusackas rusackas merged commit 5e64d65 into apache:master Aug 10, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants