fix: turn on SSL in database edit form show 500 error #16151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughhhh
changed the title
betodealmeida
requested changes
Aug 9, 2021
superset/db_engine_specs/base.py
Outdated
Comment on lines
1415
to
1420
| if isinstance(query, str): | ||
| # Make sure query isn't an empty string | ||
| if not query: | ||
| query = {} | ||
| else: | ||
| query = literal_eval(query) |
There was a problem hiding this comment.
The proper way to handle this would be fixing the frontend to always send an object, like I commented here: https://github.com/apache/superset/pull/16038/files#r681331894
We need to either fix DatabaseObject.query to have only type object here, or at least fix the FE so that it converts query correctly to an object before doing a request to the backend.
Codecov Report
@@ Coverage Diff @@
## master #16151 +/- ##
=======================================
Coverage 76.62% 76.62%
=======================================
Files 996 996
Lines 53015 53015
Branches 6744 6744
=======================================
Hits 40622 40622
Misses 12167 12167
Partials 226 226
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
betodealmeida
approved these changes
Aug 9, 2021
superset/db_engine_specs/base.py
Outdated
| @@ -18,6 +18,7 @@ | |||
| import json | |||
| import logging | |||
| import re | |||
| from ast import literal_eval | |||
There was a problem hiding this comment.
Suggested change
| from ast import literal_eval |
Comment on lines
649
to
650
| console.log('inValidate', database); | ||
| console.log(onCreate); |
There was a problem hiding this comment.
Suggested change
| console.log('inValidate', database); | |
| console.log(onCreate); |
hughhhh
force-pushed
the
hugh/fix-ssl-500
branch
from
76dfa8a
to
ebe3618
Compare
|
🏷 2021.31 |
stevenuray
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 11, 2021
* fix error for query.update * converrt before making request * fix query params * remove unchanged files * this * update tsconfig (cherry picked from commit 3f86a54)
villebro
pushed a commit
that referenced
this pull request
Aug 16, 2021
* fix error for query.update * converrt before making request * fix query params * remove unchanged files * this * update tsconfig (cherry picked from commit 3f86a54)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* fix error for query.update * converrt before making request * fix query params * remove unchanged files * this * update tsconfig
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* fix error for query.update * converrt before making request * fix query params * remove unchanged files * this * update tsconfig (cherry picked from commit 3f86a54)
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* fix error for query.update * converrt before making request * fix query params * remove unchanged files * this * update tsconfig
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* fix error for query.update * converrt before making request * fix query params * remove unchanged files * this * update tsconfig (cherry picked from commit 3f86a54)
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* fix error for query.update * converrt before making request * fix query params * remove unchanged files * this * update tsconfig (cherry picked from commit 0f55202)
mistercrunch
added
🍒 1.3.0
🍒 1.3.1
🍒 1.3.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Getting the following error for editing SSL for DBC UI.
To fix this we are going to
ast_literalto convert the string object to a dictionaryBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION