-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add config to hide some user menu items #16156
Merged
eschutho
merged 1 commit into
apache:master
from
preset-io:elizabeth/remove-user-menu-items-feature
Aug 10, 2021
Merged
feat: add config to hide some user menu items #16156
eschutho
merged 1 commit into
apache:master
from
preset-io:elizabeth/remove-user-menu-items-feature
Aug 10, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7a24898
to
d54d3f0
Compare
betodealmeida
approved these changes
Aug 10, 2021
🏷 2021.31 |
stevenuray
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 11, 2021
(cherry picked from commit 5488a8a)
villebro
pushed a commit
that referenced
this pull request
Aug 16, 2021
(cherry picked from commit 5488a8a)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
(cherry picked from commit 5488a8a)
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
(cherry picked from commit 5488a8a)
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
(cherry picked from commit 9263549)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Adding a config flag that allows admins to hide some menu items for users.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
![Superset](https://user-images.githubusercontent.com/5186919/128785492-087f625b-7c86-4a33-be06-5a5079a41638.png)
After:
![_DEV__Superset](https://user-images.githubusercontent.com/5186919/128785421-13d07139-2759-4a83-afca-955d3391c5a2.png)
TESTING INSTRUCTIONS
Add flag to config and test that the menu items are gone. With the flag the menu items should be there and the links should still work.
ADDITIONAL INFORMATION