Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add chart image info to reports from charts #16158

Merged
merged 2 commits into from
Aug 10, 2021

Conversation

eschutho
Copy link
Member

@eschutho eschutho commented Aug 9, 2021

SUMMARY

This brings in the code from eeb6967 that was lost in a feature branch merge.

It shows the same image/text options for charts on the report modal from charts that we show on the alerts/reports modals.

This also fixes a small bug where the dashboard needs to refetch reports on load.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TESTING INSTRUCTIONS

Create a chart with one of these options and ensure that the proper format was sent. Also the text options should only apply to tables.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #16158 (9f4c51a) into master (606a7bf) will decrease coverage by 0.00%.
The diff coverage is 79.41%.

❗ Current head 9f4c51a differs from pull request most recent head ab0901e. Consider uploading reports for the commit ab0901e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16158      +/-   ##
==========================================
- Coverage   76.82%   76.82%   -0.01%     
==========================================
  Files         996      996              
  Lines       52940    52966      +26     
  Branches     6732     6741       +9     
==========================================
+ Hits        40670    40689      +19     
- Misses      12045    12052       +7     
  Partials      225      225              
Flag Coverage Δ
javascript 71.20% <79.41%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/dashboard/components/Header/index.jsx 62.64% <0.00%> (-1.10%) ⬇️
...tend/src/explore/components/ExploreChartHeader.jsx 55.55% <ø> (ø)
...rset-frontend/src/components/ReportModal/index.tsx 74.46% <77.77%> (-1.44%) ⬇️
...set-frontend/src/components/ReportModal/styles.tsx 100.00% <100.00%> (ø)
...frontend/src/components/TimezoneSelector/index.tsx 97.77% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 606a7bf...ab0901e. Read the comment docs.

@eschutho eschutho requested a review from hughhhh August 10, 2021 16:18
@betodealmeida betodealmeida merged commit a310248 into apache:master Aug 10, 2021
@rosemarie-chiu
Copy link
Contributor

🏷 2021.31

stevenuray pushed a commit to preset-io/superset that referenced this pull request Aug 11, 2021
* refetch reports on props update

* add chart types to reports

(cherry picked from commit a310248)
@villebro villebro deleted the elizabeth/fix-report-reload branch August 12, 2021 06:35
@villebro villebro added the v1.3 label Aug 16, 2021
villebro pushed a commit that referenced this pull request Aug 16, 2021
* refetch reports on props update

* add chart types to reports

(cherry picked from commit a310248)
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* refetch reports on props update

* add chart types to reports
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
* refetch reports on props update

* add chart types to reports

(cherry picked from commit a310248)
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
* refetch reports on props update

* add chart types to reports
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
* refetch reports on props update

* add chart types to reports

(cherry picked from commit a310248)
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
* refetch reports on props update

* add chart types to reports

(cherry picked from commit a317773)
@mistercrunch mistercrunch added 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.31 preset-io size/L v1.3 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants