-
Notifications
You must be signed in to change notification settings - Fork 13.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add chart image info to reports from charts #16158
feat: add chart image info to reports from charts #16158
Conversation
Codecov Report
@@ Coverage Diff @@
## master #16158 +/- ##
==========================================
- Coverage 76.82% 76.82% -0.01%
==========================================
Files 996 996
Lines 52940 52966 +26
Branches 6732 6741 +9
==========================================
+ Hits 40670 40689 +19
- Misses 12045 12052 +7
Partials 225 225
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
🏷 2021.31 |
* refetch reports on props update * add chart types to reports (cherry picked from commit a310248)
* refetch reports on props update * add chart types to reports (cherry picked from commit a310248)
* refetch reports on props update * add chart types to reports
* refetch reports on props update * add chart types to reports (cherry picked from commit a310248)
* refetch reports on props update * add chart types to reports
* refetch reports on props update * add chart types to reports (cherry picked from commit a310248)
* refetch reports on props update * add chart types to reports (cherry picked from commit a317773)
SUMMARY
This brings in the code from eeb6967 that was lost in a feature branch merge.
It shows the same image/text options for charts on the report modal from charts that we show on the alerts/reports modals.
This also fixes a small bug where the dashboard needs to refetch reports on load.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Create a chart with one of these options and ensure that the proper format was sent. Also the text options should only apply to tables.
ADDITIONAL INFORMATION