Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Big Query additional parameters field doesn't keep value #16161

Merged
merged 1 commit into from Aug 10, 2021

Conversation

lyndsiWilliams
Copy link
Member

SUMMARY

This was fixed by converting the query into a URI params string.

SCREENSHOTS

fixedField

TESTING INSTRUCTIONS

From the Superset home page:

  • Hover over "Data" in the upper navigation bar
  • Click "Database"
  • Click the "+ Database" button below the navigation bar and to the right
  • Create a new BigQuery database and add an additional parameter
  • Click the edit button and observe that the additional parameters field now keeps the value

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 10, 2021

Codecov Report

Merging #16161 (c7cf47b) into master (606a7bf) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16161      +/-   ##
==========================================
- Coverage   76.82%   76.81%   -0.01%     
==========================================
  Files         996      996              
  Lines       52940    52942       +2     
  Branches     6732     6734       +2     
==========================================
  Hits        40670    40670              
- Misses      12045    12047       +2     
  Partials      225      225              
Flag Coverage Δ
javascript 71.19% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/views/CRUD/data/database/DatabaseModal/index.tsx 44.15% <0.00%> (-0.24%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 606a7bf...c7cf47b. Read the comment docs.

@betodealmeida betodealmeida merged commit 3712ee0 into apache:master Aug 10, 2021
@villebro villebro added the v1.3 label Aug 10, 2021
villebro pushed a commit that referenced this pull request Aug 10, 2021
@lyndsiWilliams lyndsiWilliams deleted the lyndsi/bq-params-fix branch August 10, 2021 16:44
stevenuray pushed a commit to preset-io/superset that referenced this pull request Aug 11, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
cccs-RyanS pushed a commit to CybercentreCanada/superset that referenced this pull request Dec 17, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 29, 2021
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2021.31 preset-io size/XS v1.3 🍒 1.3.0 🍒 1.3.1 🍒 1.3.2 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants