resize the nv3d chart to fit in the window #162
Conversation
|
@mistercrunch why don't the charts properly resize already? I'm okay with this as a quick fix but this isn't the ultimate solution because all of the vis's are currently supposed to define a resize function, so it's not getting bound to the window resize event properly. also in looking at the Slice objects resize method (the one that's not being bound to window resize events now), it calls a given vis's render AND resize methods which is not good. the vis should handle any re-rendering that needs to happen. maybe I can make a sweep for this? |
|
@williaster, I haven't tackled window resizing yet, I did define that the resize method should be in the interface and use it for widget resizing in dashboards, but haven't handled window resizing. But yeah, we should close this PR and tackle it for each view (as opposed to each viz). Should be simple enough. |
|
K sounds good. @askeys 👍 though this will fail our new linting with all of the extra spaces you have. |
|
@williaster, it sounds like @mistercrunch wants to close this rather than merge. |
|
I can try to solve this correctly this weekend, but maybe it would be better to discuss in person with @mistercrunch. |
|
yeah so maybe close this one since max fixed it with the other PR. the timeout he has on that branch is also better. |
Author: none lyft/ops_DEPRECATED@1b2095a...aceb94d TESTS WERE BYPASSED REVIEWS WERE BYPASSED
) * feat: file skeleton necessary for icicle chart visualization * feat: name changes and restructure components update package to account for clearer name and reorganized implementation for planned features * feat: fix lint errors * docs: add license file headers, adjust naming and links Add Apache license file headers to all files, adjust naming of the viz in the package.json and update the README to inform that Storybook link is unavailable but will be in the near future
) * feat: file skeleton necessary for icicle chart visualization * feat: name changes and restructure components update package to account for clearer name and reorganized implementation for planned features * feat: fix lint errors * docs: add license file headers, adjust naming and links Add Apache license file headers to all files, adjust naming of the viz in the package.json and update the README to inform that Storybook link is unavailable but will be in the near future
) * feat: file skeleton necessary for icicle chart visualization * feat: name changes and restructure components update package to account for clearer name and reorganized implementation for planned features * feat: fix lint errors * docs: add license file headers, adjust naming and links Add Apache license file headers to all files, adjust naming of the viz in the package.json and update the README to inform that Storybook link is unavailable but will be in the near future
) * feat: file skeleton necessary for icicle chart visualization * feat: name changes and restructure components update package to account for clearer name and reorganized implementation for planned features * feat: fix lint errors * docs: add license file headers, adjust naming and links Add Apache license file headers to all files, adjust naming of the viz in the package.json and update the README to inform that Storybook link is unavailable but will be in the near future
@mistercrunch @williaster adjust the size of the nvd3 chart based on the widow size.