Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add feature flags to PR template #16215

Merged
merged 2 commits into from
Aug 12, 2021

Conversation

junlincc
Copy link
Member

@junlincc junlincc commented Aug 12, 2021

SUMMARY

Helpful info for QA and keeping track of changes for FF features

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@junlincc junlincc changed the title chore:Add feature flags to bug PR template chore: Add feature flags to bug PR template Aug 12, 2021
@junlincc junlincc changed the title chore: Add feature flags to bug PR template chore: Add feature flags to PR template Aug 12, 2021
@codecov
Copy link

codecov bot commented Aug 12, 2021

Codecov Report

Merging #16215 (e23ce32) into master (ccfc95f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16215   +/-   ##
=======================================
  Coverage   76.73%   76.73%           
=======================================
  Files         996      996           
  Lines       52999    52999           
  Branches     6738     6738           
=======================================
  Hits        40668    40668           
  Misses      12102    12102           
  Partials      229      229           
Flag Coverage Δ
hive 81.36% <ø> (+0.04%) ⬆️
javascript 70.97% <ø> (ø)
mysql 81.57% <ø> (-0.05%) ⬇️
postgres 81.63% <ø> (ø)
presto 81.42% <ø> (ø)
python 82.14% <ø> (ø)
sqlite 81.23% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccfc95f...e23ce32. Read the comment docs.

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
@junlincc
Copy link
Member Author

done @villebro stamp?

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@junlincc junlincc merged commit 16a9d21 into master Aug 12, 2021
@villebro villebro deleted the Add-feature-flags-to-bug-PR-template branch August 13, 2021 07:09
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* chore:Add feature flags to bug PR template

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
* chore:Add feature flags to bug PR template

* Update .github/PULL_REQUEST_TEMPLATE.md

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>

Co-authored-by: Ville Brofeldt <33317356+villebro@users.noreply.github.com>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants