fix(explore): conditional formatting value validators #16230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
approved these changes
Aug 12, 2021
...nd/src/explore/components/controls/ConditionalFormattingControl/FormattingPopoverContent.tsx
Outdated
Show resolved
Hide resolved
stevenuray
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 12, 2021
* fix(explore): conditional formatting value validators * Fix typing, make validator more generic * Remove commented code (cherry picked from commit a16e290)
|
🏷 2021.31 |
villebro
pushed a commit
that referenced
this pull request
Aug 16, 2021
* fix(explore): conditional formatting value validators * Fix typing, make validator more generic * Remove commented code (cherry picked from commit a16e290)
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* fix(explore): conditional formatting value validators * Fix typing, make validator more generic * Remove commented code
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
* fix(explore): conditional formatting value validators * Fix typing, make validator more generic * Remove commented code (cherry picked from commit a16e290)
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* fix(explore): conditional formatting value validators * Fix typing, make validator more generic * Remove commented code
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
* fix(explore): conditional formatting value validators * Fix typing, make validator more generic * Remove commented code (cherry picked from commit a16e290)
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
* fix(explore): conditional formatting value validators * Fix typing, make validator more generic * Remove commented code (cherry picked from commit 365164d)
mistercrunch
added
🍒 1.3.0
🍒 1.3.1
🍒 1.3.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR casts number-like strings to numbers in order to ensure correct value validation in conditional formatting.
Before, we were comparing values that were actually strings and not numbers, which caused incorrect validation errors.
I also did some refactoring to avoid unnecessary rerenders.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before: see linked issue
After:
https://user-images.githubusercontent.com/15073128/129187281-ab83bcde-870c-4715-a733-9448bdbd9c84.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
CC @vnnw @junlincc @jinghua-qa