Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add function list to auto-complete to Clickhouse datasource #16234

Merged
merged 5 commits into from
Aug 26, 2021
Merged

feat: add function list to auto-complete to Clickhouse datasource #16234

merged 5 commits into from
Aug 26, 2021

Conversation

Slach
Copy link
Contributor

@Slach Slach commented Aug 12, 2021

SUMMARY

add function list to auto-complete to Clickhouse datasource
Fixes #15477

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TESTING INSTRUCTIONS

use https://gist.github.com/Slach/ad926dfa30ceb4fe1d168c00c3da98e0#file-bootstrap-dev-sh
bootstrap-dev.sh script
open https://localhost:8088
add clickhouse+native://default@clickhouse:9000/default as new datasource
after add, open SQLlab and try to use auto-complete

@codecov
Copy link

codecov bot commented Aug 13, 2021 •
edited
Loading

Codecov Report

Merging #16234 (2e003ce) into master (575ee24) will decrease coverage by 0.10%.
The diff coverage is 39.13%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16234      +/-   ##
==========================================
- Coverage   76.58%   76.48%   -0.11%     
==========================================
  Files        1000     1000              
  Lines       53481    53508      +27     
  Branches     6815     6815              
==========================================
- Hits        40958    40924      -34     
- Misses      12287    12348      +61     
  Partials      236      236
Flag Coverage Δ
hive 81.24% <39.13%> (+<0.01%) ⬆️
mysql 81.45% <39.13%> (-0.08%) ⬇️
postgres 81.47% <39.13%> (-0.08%) ⬇️
presto ?
python 81.85% <39.13%> (-0.21%) ⬇️
sqlite ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/clickhouse.py 66.03% <39.13%> (-21.06%) ⬇️
superset/db_engine_specs/presto.py 84.51% <0.00%> (-5.44%) ⬇️
superset/db_engine_specs/sqlite.py 91.89% <0.00%> (-5.41%) ⬇️
superset/connectors/sqla/utils.py 88.23% <0.00%> (-3.93%) ⬇️
superset/utils/celery.py 86.20% <0.00%> (-3.45%) ⬇️
superset/result_set.py 96.77% <0.00%> (-1.62%) ⬇️
superset/connectors/sqla/models.py 88.28% <0.00%> (-1.43%) ⬇️
superset/utils/cache.py 73.58% <0.00%> (-0.95%) ⬇️
superset/models/core.py 89.14% <0.00%> (-0.26%) ⬇️
superset/charts/commands/importers/v1/__init__.py 100.00% <0.00%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 575ee24...2e003ce. Read the comment docs.

@zhaoyongjie zhaoyongjie changed the title add function list to auto-complete to Clickhouse datasource feat: add function list to auto-complete to Clickhouse datasource Aug 13, 2021
@Slach
add function list to auto-complete to Clickhouse datasource, fix apac…
afd63bd 
…he#15477

fix review comments apache#16234 (comment)

Signed-off-by: Slach <bloodjazman@gmail.com>
@Slach Slach requested a review from zhaoyongjie August 22, 2021 17:04
@zhaoyongjie
Copy link
Member

Hi @Slach, Thanks for the following updates. LGTM excepts CI didn't pass. Could you have got time to fix it?

@Slach
Copy link
Contributor Author

Slach commented Aug 23, 2021 •
edited
Loading

@zhaoyongjie try to fix CI/CD 33cbd25
how to trigger CD/CD workflow?

@zhaoyongjie
Copy link
Member

@zhaoyongjie try to fix CI/CD 33cbd25
how to trigger CD/CD workflow?

I will trigger the CI. thanks!

@Slach
fix black formatting
368c2a6 
Signed-off-by: Slach <bloodjazman@gmail.com>
@Slach
Copy link
Contributor Author

Slach commented Aug 23, 2021

@zhaoyongjie sorry, i forgot apply black formatter
fixed on 368c2a6

@Slach
fix isort pre-commit hook
2e003ce 
Signed-off-by: Slach <bloodjazman@gmail.com>
@Slach
Copy link
Contributor Author

Slach commented Aug 23, 2021

@zhaoyongjie ;) i also apply isort to clickhouse.py
2e003ce
could you trigger ci/cd again?

@zhaoyongjie
Copy link
Member

@zhaoyongjie ;) i also apply isort to clickhouse.py
2e003ce
could you trigger ci/cd again?

Sure.

@Slach
Copy link
Contributor Author

Slach commented Aug 23, 2021

@zhaoyongjie could you suggest about cypress-matrix tests?
https://github.com/apache/superset/pull/16234/checks?check_run_id=3398189875
look like it not related to my changes

@zhaoyongjie
Copy link
Member

@zhaoyongjie could you suggest about cypress-matrix tests?
https://github.com/apache/superset/pull/16234/checks?check_run_id=3398189875
look like it not related to my changes

Cypress might be stuck in unknown reason. I will restart this job.

@Slach
Copy link
Contributor Author

Slach commented Aug 23, 2021

@zhaoyongjie looks like all checks passed, could we merge pull request?

zhaoyongjie
zhaoyongjie approved these changes Aug 26, 2021
View reviewed changes
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

LGTM, thanks for the contribution!

@zhaoyongjie zhaoyongjie merged commit 1badcae into apache:master Aug 26, 2021
amitmiran137 pushed a commit to nielsen-oss/superset that referenced this pull request Aug 26, 2021
Merge remote-tracking branch 'upstream/master' into feat/fileter_set
930863b 
* upstream/master: (25 commits)
  chore(ci): bump pylint to 2.10.2 (apache#16463)
  fix: prevent page crash when chart can't render (apache#16464)
  chore: fixed slack invite link (apache#16466)
  fix(native-filters): handle null values in value filter (apache#16460)
  feat: add function list to auto-complete to Clickhouse datasource (apache#16234)
  refactor(explore): improve typing for Dnd controls (apache#16362)
  fix(explore): update overwrite button on perm change (apache#16437)
  feat: Draggable and Resizable Modal (apache#16394)
  refactor: sql_json view endpoint (apache#16441)
  fix(dashboard): undo and redo buttons weird alignment  (apache#16417)
  fix: setupPlugin in chart list page (apache#16413)
  fix: Disable Slack notification method if no api token (apache#16367)
  feat: add Shillelagh DB engine spec (apache#16416)
  fix: copy to Clipboard order (apache#16299)
  docs: make FEATURE_FLAGS.md reference a link (apache#16415)
  chore(viz): bump superset-ui to 0.17.87 (apache#16420)
  feat: add activate command (apache#16404)
  Revert "fix(explore): let admin overwrite slice (apache#16290)" (apache#16408)
  fix(explore): retain chart ownership on query context update (apache#16419)
  chore: Removes the TODOs and uses the default page size (apache#16422)
  ...
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
@Slach
feat: add function list to auto-complete to Clickhouse datasource (ap…
b4e9223 
…ache#16234)

* add function list to auto-complete to Clickhouse datasource, fix apache#15477

Signed-off-by: Slach <bloodjazman@gmail.com>

* add function list to auto-complete to Clickhouse datasource, fix apache#15477
fix review comments apache#16234 (comment)

Signed-off-by: Slach <bloodjazman@gmail.com>

* fix CI/CD https://github.com/apache/superset/pull/16234/checks?check_run_id=3396235776 and https://github.com/apache/superset/pull/16234/checks?check_run_id=3396235707

Signed-off-by: Slach <bloodjazman@gmail.com>

* fix black formatting

Signed-off-by: Slach <bloodjazman@gmail.com>

* fix isort pre-commit hook

Signed-off-by: Slach <bloodjazman@gmail.com>
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@Slach
feat: add function list to auto-complete to Clickhouse datasource (ap…
2de16e5 
…ache#16234)

* add function list to auto-complete to Clickhouse datasource, fix apache#15477

Signed-off-by: Slach <bloodjazman@gmail.com>

* add function list to auto-complete to Clickhouse datasource, fix apache#15477
fix review comments apache#16234 (comment)

Signed-off-by: Slach <bloodjazman@gmail.com>

* fix CI/CD https://github.com/apache/superset/pull/16234/checks?check_run_id=3396235776 and https://github.com/apache/superset/pull/16234/checks?check_run_id=3396235707

Signed-off-by: Slach <bloodjazman@gmail.com>

* fix black formatting

Signed-off-by: Slach <bloodjazman@gmail.com>

* fix isort pre-commit hook

Signed-off-by: Slach <bloodjazman@gmail.com>
@siegfriedweber siegfriedweber mentioned this pull request Feb 9, 2022
Closed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaoyongjie zhaoyongjie zhaoyongjie approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Clickhouse] [Feature Request] SQL editor autocomplete for functions and args
3 participants
@Slach @zhaoyongjie @mistercrunch