fix: check roles before fetching reports #16260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lyndsiWilliams is working on tests for this flow. |
betodealmeida
approved these changes
Aug 14, 2021
Codecov Report
@@ Coverage Diff @@
## master #16260 +/- ##
==========================================
- Coverage 76.72% 76.70% -0.03%
==========================================
Files 997 997
Lines 53238 53238
Branches 6772 6774 +2
==========================================
- Hits 40847 40834 -13
- Misses 12161 12174 +13
Partials 230 230
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
stevenuray
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 14, 2021
(cherry picked from commit 3709131)
villebro
pushed a commit
that referenced
this pull request
Aug 16, 2021
(cherry picked from commit 3709131)
amitmiran137
pushed a commit
that referenced
this pull request
Aug 16, 2021
…gies * upstream/master: (64 commits) check roles before fetching reports (#16260) chore: upgrade mypy and add type guards (#16227) fix: pivot columns with ints for name (#16259) chore(pylint): Bump Pylint to 2.9.6 (#16146) fix examples tab for dashboard (#16253) chore: bump superset-ui packages to 0.17.84 (#16251) chore: Shows the dataset description in the gallery dropdown (#16200) fix(Dashboard): Omnibar dropdown visibility and keyboard commands (#16168) chore: bump py version for integration test (#16213) fix: skip perms on query context update (#16250) refactor: external metadata fetch API (#16193) feat(dao): admin can remove self from object owners (#15149) fix(dashboard): cross filter chart highlight when filters badge icon clicked (#16233) fix: validate_parameters and query (#16241) fix: Remove Advanced Analytics tag for 2 charts (#16240) Revert "feat: Changing Dataset names (#16199)" (#16235) feat: Allow users to connect via legacy SQLA form (#16201) fix: remove encryption from db params (#16214) fix(Explore): Show the tooltip only when label does not fit the container in METRICS/FILTERS/GROUP BY/SORT BY of the DATA panel (#16060) Show/hide tooltips (#16192) ... # Conflicts: # superset/tasks/caching/cache_strategy.py
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
cccs-RyanS
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Dec 17, 2021
(cherry picked from commit 3709131)
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 29, 2021
(cherry picked from commit 3709131)
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
(cherry picked from commit de5d157)
mistercrunch
added
🍒 1.3.0
🍒 1.3.1
🍒 1.3.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This adds an extra role authorization check before fetching reports to fix a bug that was showing an unnecessary error.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Original error:
TESTING INSTRUCTIONS
As a gamma user, you should be able to go to a chart or dashboard and not receive errors about not being able to fetch reports.
ADDITIONAL INFORMATION