fix: Fix table height in Change dataset modal when pagination is off

[geido]

SUMMARY

This PR fixes an issue with the height of the table inside the Change dataset modal when the pagination is off, which was causing a blank space to appear.

BEFORE

DEV.Cross.Chan.mp4

AFTER

DEV.Pivot.Tabl.1.mp4

TESTING INSTRUCTIONS

1. Open a chart in Explore
2. Click on Change dataset
3. Observe the table height and make sure there is no blank space at the bottom

ADDITIONAL INFORMATION

• Has associated issue: Fixes explore: Change dataset modal shows unnecessary blank space #16249
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[kgabryje]

Looks great! Thanks for the improvement

[geido]

/testenv up

[github-actions]

@geido Ephemeral environment spinning up at http://34.220.104.198:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[michael-s-molina]

When we dismiss the warning message, we have a blank space at the bottom.

Screen.Recording.2021-08-16.at.4.26.39.PM.mov

[geido]

Hello @michael-s-molina that is a different issue which isn't related to my changes and that affect master as well. I will file an issue for that problem and submit a separate fix when these changes are merged in.

See above

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.

[michael-s-molina]

Hello @michael-s-molina that is a different issue which isn't related to my changes and that affect master as well. I will file an issue for that problem and submit a separate fix when these changes are merged in.

@geido I added a comment about improving the criteria of splitting the PRs here. For me, this is the perfect example where we will add unnecessary overhead to a simple fix that should only be another commit.

[geido]

@michael-s-molina I agree this would have worked perfectly in one PR. However, my intention here was to fix the most perceivable issue first and then work on a separate PR to revisit this problem entirely. In fact, this issue has been coming back in a way or another few times and I believe it requires a more comprehensive solution and probably some refactoring work as well.