fix: improve pivot post-processing #16289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
betodealmeida
force-pushed
the
ch22329
branch
2 times, most recently
from
c737916
to
58a025f
Compare
Codecov Report
@@ Coverage Diff @@
## master #16289 +/- ##
==========================================
- Coverage 76.64% 76.53% -0.12%
==========================================
Files 997 997
Lines 53246 53264 +18
Branches 6777 6777
==========================================
- Hits 40808 40763 -45
- Misses 12208 12271 +63
Partials 230 230
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
eschutho
reviewed
Aug 17, 2021
| ] | ||
| parts: List[Any] = list(label) | ||
| metric = parts[-1] | ||
| parts[-1] = metrics.index(metric) |
There was a problem hiding this comment.
would it be more or less pythonic to pop and then push instead?
eschutho
approved these changes
Aug 17, 2021
There was a problem hiding this comment.
@betodealmeida walked me through this and it looks good. The tests are fantastic!
betodealmeida
added a commit
to preset-io/superset
that referenced
this pull request
Aug 17, 2021
* fix: improve pivot post-processing * Add tests * Trim space from column name
|
🏷️ 2021.31 |
henryyeh
pushed a commit
to preset-io/superset
that referenced
this pull request
Aug 19, 2021
* fix: improve pivot post-processing * Add tests * Trim space from column name (cherry picked from commit ac8e54d)
|
@betodealmeida the new post processing seems to not export row headers when choosing the csv output?
|
villebro
pushed a commit
that referenced
this pull request
Sep 22, 2021
* fix: improve pivot post-processing * Add tests * Trim space from column name (cherry picked from commit ac8e54d)
|
I see this one is tagged to be included in v1.3, but it seems to me that the missing headers is quite crucial for a csv export? |
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* fix: improve pivot post-processing * Add tests * Trim space from column name
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* fix: improve pivot post-processing * Add tests * Trim space from column name
mistercrunch
added
🍒 1.3.1
🍒 1.3.2
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes many cases when applying the pivot table post-processing.
I reimplemented the algorithm from scratch to make sure it matches the JS logic, testing as many combinations as I could and comparing the Python results with the JS visualization.
For each of those cases I added a unit test showing the pivot. The resulting table in each of the unit tests matches the table from the visualization.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
N/A
ADDITIONAL INFORMATION