Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revert "disable text reports for now" #16296

Merged
merged 1 commit into from
Aug 17, 2021

Conversation

betodealmeida
Copy link
Member

This reverts commit ee9a384.

SUMMARY

This is now fixed.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@betodealmeida betodealmeida changed the title Revert "fix: disable text reports for now (#16257)" Revert "fix: disable text reports for now)" Aug 17, 2021
@betodealmeida betodealmeida changed the title Revert "fix: disable text reports for now)" Revert "fix: disable text reports for now" Aug 17, 2021
@betodealmeida betodealmeida changed the title Revert "fix: disable text reports for now" fix: revert "disable text reports for now" Aug 17, 2021
@codecov
Copy link

codecov bot commented Aug 17, 2021

Codecov Report

Merging #16296 (6542354) into master (f581e04) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16296   +/-   ##
=======================================
  Coverage   76.54%   76.54%           
=======================================
  Files         999      999           
  Lines       53376    53376           
  Branches     6817     6817           
=======================================
+ Hits        40856    40858    +2     
+ Misses      12283    12281    -2     
  Partials      237      237           
Flag Coverage Δ
javascript 70.77% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/components/ReportModal/index.tsx 73.68% <100.00%> (+1.05%) ⬆️
...frontend/src/views/CRUD/alert/AlertReportModal.tsx 62.88% <100.00%> (+0.23%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f581e04...6542354. Read the comment docs.

@betodealmeida betodealmeida merged commit 3c0aefb into apache:master Aug 17, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants