Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Make View Query Modal draggable and resizable in Dashboard #16447

Merged
merged 1 commit into from
Aug 31, 2021
Merged

chore: Make View Query Modal draggable and resizable in Dashboard #16447

merged 1 commit into from
Aug 31, 2021

Conversation

geido
Copy link
Member

@geido geido commented Aug 25, 2021

SUMMARY

It enables resizable and draggable properties for the "View query" Modal in Dashboard.

BEFORE

Screen Shot 2021-08-25 at 16 21 33

AFTER

a.new.dashboard.mp4

TESTING INSTRUCTIONS

  1. Open a Dashboard
  2. Click on "View query" from the Chart menu
  3. Drag and resize the Modal

ADDITIONAL INFORMATION

  • Has associated issue: [Viewquery]Allow View Query Screen to move around #16205
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@geido
Copy link
Member Author

geido commented Aug 25, 2021

@codecov
Copy link

codecov bot commented Aug 25, 2021

Codecov Report

Merging #16447 (4a1cb6d) into master (db11c3e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16447   +/-   ##
=======================================
  Coverage   76.41%   76.41%           
=======================================
  Files        1002     1002           
  Lines       53635    53635           
  Branches     6851     6851           
=======================================
  Hits        40985    40985           
  Misses      12411    12411           
  Partials      239      239           
Flag Coverage Δ
javascript 70.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...dashboard/components/SliceHeaderControls/index.tsx 75.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update db11c3e...4a1cb6d. Read the comment docs.

@geido
Copy link
Member Author

geido commented Aug 25, 2021

/testenv up

@github-actions
Copy link
Contributor

@geido Ephemeral environment spinning up at http://34.221.177.62:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@junlincc
Copy link
Member

LGTM! thanks for the UX upgrade :) It will be great if the page remains scrollable when the modal is open. we can make incremental improvement as users request.

@junlincc junlincc added the need:review Requires a code review label Aug 25, 2021
@geido
Copy link
Member Author

geido commented Aug 26, 2021

LGTM! thanks for the UX upgrade :) It will be great if the page remains scrollable when the modal is open. we can make incremental improvement as users request.

That's a very nice suggestion @junlincc. I will attempt this change in a separate PR asap

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@geido geido merged commit f001c44 into apache:master Aug 31, 2021
@geido geido deleted the chore/draggable-resizable-view-query-dashboard branch August 31, 2021 09:46
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@jinghua-qa
Copy link
Member

test cases added

opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:review Requires a code review size/XS test:case 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants