Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove myself from codeowners on Preset integration #16470

Merged
merged 1 commit into from
Aug 30, 2021

Conversation

willbarrett
Copy link
Member

SUMMARY

I'm no longer with Preset, so I shouldn't be a codeowner on Preset's integration anymore :)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@craig-rueda craig-rueda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad :(

@codecov
Copy link

codecov bot commented Aug 26, 2021

Codecov Report

Merging #16470 (17665d6) into master (577ede4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #16470   +/-   ##
=======================================
  Coverage   76.61%   76.61%           
=======================================
  Files        1002     1002           
  Lines       53671    53671           
  Branches     6857     6857           
=======================================
  Hits        41121    41121           
  Misses      12311    12311           
  Partials      239      239           
Flag Coverage Δ
hive 81.26% <ø> (+<0.01%) ⬆️
javascript 70.82% <ø> (ø)
mysql 81.52% <ø> (ø)
postgres 81.55% <ø> (ø)
presto 81.36% <ø> (ø)
python 82.05% <ø> (ø)
sqlite 81.19% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 577ede4...17665d6. Read the comment docs.

@willbarrett willbarrett merged commit 8aa24e5 into master Aug 30, 2021
@willbarrett willbarrett deleted the wbarrett/remove-self-from-codeowners branch August 30, 2021 22:14
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants