chore(pylint): Remove top-level disable #16589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
force-pushed
the
john-bodley--pylint-remove-top-level-disable
branch
from
20a8566
to
1ecd28d
Compare
john-bodley
force-pushed
the
john-bodley--pylint-remove-top-level-disable
branch
3 times, most recently
from
e264479
to
50fd6a3
Compare
Codecov Report
@@ Coverage Diff @@
## master #16589 +/- ##
==========================================
- Coverage 76.93% 76.76% -0.18%
==========================================
Files 1007 1007
Lines 54112 54101 -11
Branches 7346 7367 +21
==========================================
- Hits 41633 41531 -102
- Misses 12239 12330 +91
Partials 240 240
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
john-bodley
force-pushed
the
john-bodley--pylint-remove-top-level-disable
branch
from
50fd6a3
to
2a00cf1
Compare
john-bodley
commented
Sep 5, 2021
| from superset.utils.public_interfaces import compute_hash, get_warning_message | ||
| from tests.integration_tests.base_tests import SupersetTestCase |
| hashes = { | ||
| dummy_sql_query_mutator: "Kv%NM3b;7BcpoD2wbPkW", | ||
| } | ||
| hashes: Dict[Callable[..., Any], str] = {} |
There was a problem hiding this comment.
There was issues in referencing the `app.config["SQL_QUERY_MUTATOR"] because i) the app was the test rather than the default config, and ii) the test wasn't running within an app context. Furthermore it's unclear why the default SQL query mutator was needed explicit checking compared to say any other of the default interfaces.
john-bodley
force-pushed
the
john-bodley--pylint-remove-top-level-disable
branch
2 times, most recently
from
bc8e960
to
13ca5c4
Compare
john-bodley
force-pushed
the
john-bodley--pylint-remove-top-level-disable
branch
from
13ca5c4
to
11059cf
Compare
john-bodley
force-pushed
the
john-bodley--pylint-remove-top-level-disable
branch
from
8f5ba9f
to
02f2710
Compare
john-bodley
commented
Sep 14, 2021
| @@ -52,25 +50,13 @@ | |||
| from superset.utils.dates import now_as_float | |||
| from superset.utils.decorators import stats_timing | |||
|
|
|||
|
|
|||
| # pylint: disable=unused-argument, redefined-outer-name | |||
| def dummy_sql_query_mutator( | |||
There was a problem hiding this comment.
Note I don't believe moving this is to config.py is a breaking change since any custom logic would already be defined in a custom config override.
ktmud
approved these changes
Sep 15, 2021
| @@ -984,7 +985,14 @@ def CSV_TO_HIVE_UPLOAD_DIRECTORY_FUNC( | |||
| # def SQL_QUERY_MUTATOR(sql, user_name, security_manager, database): | |||
| # dttm = datetime.now().isoformat() | |||
| # return f"-- [SQL LAB] {username} {dttm}\n{sql}" | |||
| SQL_QUERY_MUTATOR = None | |||
| def SQL_QUERY_MUTATOR( # pylint: disable=invalid-name,unused-argument | |||
There was a problem hiding this comment.
@ktmud Pylint doesn’t like capitals in function names.
opus-42
pushed a commit
to opus-42/incubator-superset
that referenced
this pull request
Nov 14, 2021
* chore(pylint): Remove top-level disable * Update examples.py * Update command.py Co-authored-by: John Bodley <john.bodley@airbnb.com>
QAlexBall
pushed a commit
to QAlexBall/superset
that referenced
this pull request
Dec 28, 2021
* chore(pylint): Remove top-level disable * Update examples.py * Update command.py Co-authored-by: John Bodley <john.bodley@airbnb.com>
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Generally top-level Pylint disable should be discouraged (except for a few necessary exceptions related to imports and number of lines) as they can mask a number of issues. This PR moves top-level Pylint disable messages to the relevant scope (and fixes a number of issues which surfaced by doing so).
Note the bulk of the changes are in
superset/viz.pywhich I gather could be slated for deprecation.TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION