Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: dashboard standalone class not added when parameter set #16619

Merged
merged 2 commits into from
Apr 20, 2022
Merged

fix: dashboard standalone class not added when parameter set #16619

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f874084
fix: dashboard standalone class not added when parameter set
trepmag Sep 7, 2021
ca7dc77
Merge branch 'master' into dashboard_standalone_class
villebro Apr 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions superset/views/core.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1894,6 +1894,8 @@ def dashboard(
request.args.get(utils.ReservedUrlParameters.EDIT_MODE.value) == "true"
)

standalone_mode = ReservedUrlParameters.is_standalone_mode()

add_extra_log_payload(
dashboard_id=dashboard.id,
dashboard_version="v2",
Expand All @@ -1912,6 +1914,7 @@ def dashboard(
bootstrap_data=json.dumps(
bootstrap_data, default=utils.pessimistic_json_iso_dttm_ser
),
standalone_mode=standalone_mode,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: since standalone_mode isn't being reused, I'd prefer to place it inline here, like

standalone_mode=ReservedUrlParameters.is_standalone_mode(),

)

@api
Expand Down