Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Writes the tests for the new Select component #16638

Merged
merged 2 commits into from
Sep 9, 2021

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Writes the tests for the new Select component and fixes the bugs found while writing the tests.

@junlincc @rusackas

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2021-09-08 at 3 36 49 PM

TESTING INSTRUCTIONS

All tests should pass.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 8, 2021

Codecov Report

Merging #16638 (c96507a) into master (37c2020) will increase coverage by 0.09%.
The diff coverage is 88.88%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16638      +/-   ##
==========================================
+ Coverage   76.64%   76.74%   +0.09%     
==========================================
  Files        1003     1004       +1     
  Lines       53959    53971      +12     
  Branches     7330     7335       +5     
==========================================
+ Hits        41358    41418      +60     
+ Misses      12362    12314      -48     
  Partials      239      239              
Flag Coverage Δ
javascript 71.28% <88.88%> (+0.19%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Select/Select.tsx 89.95% <88.88%> (+17.30%) ⬆️
superset-frontend/src/dashboard/actions/hydrate.js 1.69% <0.00%> (-0.03%) ⬇️
superset-frontend/src/SqlLab/actions/sqlLab.js 59.01% <0.00%> (ø)
...shboard/util/charts/getFormDataWithExtraFilters.ts 83.87% <0.00%> (ø)
...nd/src/explore/components/DatasourcePanel/types.ts 100.00% <0.00%> (ø)
...ontrols/DndColumnSelectControl/DndMetricSelect.tsx 41.87% <0.00%> (+0.47%) ⬆️
superset-frontend/src/components/Select/utils.ts 96.15% <0.00%> (+34.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37c2020...c96507a. Read the comment docs.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is amazing work! ❤️ This should really help protect us against regressions and make it easier to add new features and refinements without fear of breaking existing functionality.

Comment on lines 189 to 190
const firstOption = OPTIONS[0];
const secondOption = OPTIONS[1];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: some of these might look nicer by doing the ol'

Suggested change
const firstOption = OPTIONS[0];
const secondOption = OPTIONS[1];
const [firstOption, secondOption] = OPTIONS;

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is stellar work!

@michael-s-molina michael-s-molina merged commit e9e6c5d into apache:master Sep 9, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
* chore: Writes the tests for the new Select component

* Uses array destructuring
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
* chore: Writes the tests for the new Select component

* Uses array destructuring
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XL 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants