Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: sql_json view endpoint: separate save query concern #16646

Merged
merged 1 commit into from
Sep 9, 2021

Conversation

ofekisr
Copy link
Contributor

@ofekisr ofekisr commented Sep 9, 2021

SUMMARY
The sql_json view code in superset core view without any "clean code" standard and it does not adopt any software development principle.
This is the sixth PR in the sequence of future PRs (previous PR) try to solve it by refactoring the code.
The PR focus of separate "save new query" concern into ad hod method so the code will be cleaner
there are no logic changes so it implies on the current tests.

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #16646 (c569a3f) into master (6465ee7) will decrease coverage by 0.14%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #16646      +/-   ##
==========================================
- Coverage   76.70%   76.56%   -0.15%     
==========================================
  Files        1004     1004              
  Lines       53983    53983              
  Branches     7335     7335              
==========================================
- Hits        41408    41332      -76     
- Misses      12336    12412      +76     
  Partials      239      239              
Flag Coverage Δ
hive ?
mysql 81.55% <66.66%> (-0.04%) ⬇️
postgres 81.62% <66.66%> (+<0.01%) ⬆️
python 81.70% <66.66%> (-0.28%) ⬇️
sqlite 81.27% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 75.70% <66.66%> (+0.07%) ⬆️
superset/db_engines/hive.py 0.00% <0.00%> (-82.15%) ⬇️
superset/db_engine_specs/hive.py 69.80% <0.00%> (-16.87%) ⬇️
superset/views/database/mixins.py 81.03% <0.00%> (-1.73%) ⬇️
superset/db_engine_specs/presto.py 83.47% <0.00%> (-1.05%) ⬇️
superset/db_engine_specs/base.py 88.00% <0.00%> (-0.39%) ⬇️
superset/connectors/sqla/models.py 88.04% <0.00%> (-0.24%) ⬇️
superset/utils/core.py 89.76% <0.00%> (-0.13%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6465ee7...c569a3f. Read the comment docs.

Copy link
Member

@amitmiran137 amitmiran137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple method extraction
LGTM!

@amitmiran137 amitmiran137 merged commit df7d9d5 into apache:master Sep 9, 2021
opus-42 pushed a commit to opus-42/incubator-superset that referenced this pull request Nov 14, 2021
QAlexBall pushed a commit to QAlexBall/superset that referenced this pull request Dec 28, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.4.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 1.4.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants